[MPS] Fix executor_runner_mps and mpsdelegate linking with pybind #3248
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Summary of changes: - fixes mps_executor_runner build - previously it would fail to build previously due to incorrect linking with portable ops - fixes `mpsdelegate` linking with `pybind` lib - added tests to check correctness directly through pybind - added a helper file (`bench_utils.py`) to help measure models forward pass between PyTorch MPS and ExecuTorch MPS Testing (will run both AOT and runtime if MPS was built with pybind): - `./install_requirements.sh --pybind mps` - invoke a single unit test: `python3 -m unittest backends.apple.mps.test.test_mps_indexing_ops -v -k test_mps_indexing_get_1`. - invoke all tests from a file: `python3 -m unittest backends.apple.mps.test.test_mps_indexing_ops -v` cc cccclai , shoumikhin Pull Request resolved: #3222 Reviewed By: shoumikhin Differential Revision: D56447888 Pulled By: cccclai fbshipit-source-id: 5cbbcbf8df34f29e23a1854df72f764337a9df76 (cherry picked from commit 6c30eea)
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/3248
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit d5ec4a3 with merge base d3326a2 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
There are trunk failures you need to fix |
I think that's unrelated - rerun one job and that passes. Will rerun the other job |
|
all jobs pass after rerun |
guangy10
approved these changes
Apr 23, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes:
mpsdelegatelinking withpybindlibbench_utils.py) to help measure models forward pass between PyTorch MPS and ExecuTorch MPSTesting (will run both AOT and runtime if MPS was built with pybind):
./install_requirements.sh --pybind mpspython3 -m unittest backends.apple.mps.test.test_mps_indexing_ops -v -k test_mps_indexing_get_1.python3 -m unittest backends.apple.mps.test.test_mps_indexing_ops -vcc @cccclai , @shoumikhin