Skip to content

[pyproject.toml] Add a dependency on torch==2.3 #3277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 24, 2024

Conversation

dbort
Copy link
Contributor

@dbort dbort commented Apr 24, 2024

This is the version that the release/0.2 version of executorch depends on.

Also update the CI setup scripts so it can find this version before it's available on PyPI

Copy link

pytorch-bot bot commented Apr 24, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/3277

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures

As of commit 57743df with merge base d3326a2 (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 24, 2024
@dbort dbort force-pushed the pip-torch-version branch from 3ed2e04 to 01a4a90 Compare April 24, 2024 05:17
dbort added 3 commits April 24, 2024 10:09
Remove `requires-python = ">=3.10"`. This caused the linter to use a new
`with` syntax that was added in python 3.10, but we want to eventualy
supoort older versions of python.
When installing the executorch pip package for CI jobs, look on the
pytorch servers when resolving dependencies. This lets the executorch
package depend on pytorch pre-release and nightly versions.

Also run the llava setup with `-x` to make it easier to debug failures.
This is the version that the release/0.2 version of executorch depends
on. We should not pick this back into main.
@dbort dbort force-pushed the pip-torch-version branch from 01a4a90 to 57743df Compare April 24, 2024 17:09
@dbort dbort mentioned this pull request Apr 24, 2024
@guangy10 guangy10 merged commit 399138e into pytorch:release/0.2 Apr 24, 2024
38 of 39 checks passed
@dbort dbort deleted the pip-torch-version branch April 24, 2024 17:53
@mergennachin mergennachin mentioned this pull request Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants