Skip to content

[RELEASE ONLY] Android custom op registration #3284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 24, 2024

Conversation

kirklandsign
Copy link
Contributor

@kirklandsign kirklandsign commented Apr 24, 2024

In main branch, the custom op registration is using new API. However, this is not present in release/0.2. We need it for LLAMA to work.

Copy link

pytorch-bot bot commented Apr 24, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/3284

Note: Links to docs will display an error until the docs builds have been completed.

❌ 3 New Failures

As of commit 670c1f8 with merge base d3326a2 (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 24, 2024
@kirklandsign kirklandsign requested a review from guangy10 April 24, 2024 06:18
@kirklandsign kirklandsign force-pushed the android-custom-ops branch 2 times, most recently from a29d425 to 6dd613a Compare April 24, 2024 07:21
@guangy10
Copy link
Contributor

There are apple jobs failure which doesn't look relevant

@guangy10 guangy10 merged commit 904e989 into pytorch:release/0.2 Apr 24, 2024
86 of 89 checks passed
@mergennachin mergennachin mentioned this pull request Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants