Skip to content

[MPS] Update MPS documentation; add helper script to build mps_executor_runner #3329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

DenisVieriu97
Copy link
Collaborator

Summary of changes:

  • Update MPS documentation to reflect all changes since previous release
  • Add helper script to build mps_executor_runner

Testing:

  • Verified that mps_executor_runner builds correctly:
./examples/apple/mps/scripts/build_mps_executor_runner.sh
/examples/apple/mps/scripts/build_mps_executor_runner.sh --Debug

Verified that the docs are building correctly:

cd docs
make html

cc @shoumikhin, @cccclai

Copy link

pytorch-bot bot commented Apr 24, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/3329

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures

As of commit cfefe29 with merge base d3326a2 (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 24, 2024
@shoumikhin shoumikhin merged commit 2d75a0b into pytorch:release/0.2 Apr 24, 2024
34 of 35 checks passed
@DenisVieriu97
Copy link
Collaborator Author

DenisVieriu97 commented Apr 24, 2024

❌ 1 New Failure, 2 Pending

As of commit cfefe29 with merge base d3326a2 (image):

NEW FAILURE - The following job has failed:
Apple / test-demo-ios / macos-job (gh)
RuntimeError: Command bash /Users/runner/work/_temp/exec_script failed with exit code 1
This comment was automatically generated by Dr. CI and updates every 15 minutes.

This failed because it didn't have the changes from: #3327.
That one just got merged and it fixes this issue (test-ios-mps passes there).

@mergennachin mergennachin mentioned this pull request Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants