Skip to content

Add EXECUTORCH_SEPARATE_FLATCC_HOST_PROJECT cmake option (#3356) #3357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 25, 2024

Conversation

dbort
Copy link
Contributor

@dbort dbort commented Apr 25, 2024

Summary:
Currently, we always build two copies of the flatcc targets, just in case we happen to be cross-compiling. But because the flatcc project puts its binaries in the source directory, those two copies can interfere with each other.

We don't need to build two copies when not cross-compiling, so add a new option to avoid the second "host" build.

Eventually we should only enable this when cross-compiling, but for now disable it when building the pip package (which is never cross-compiled).

Pull Request resolved: #3356

Test Plan: rm -rf pip-out && ./install_requirements.sh succeeded. Looking in the pip-out/temp.*/cmake-out directory, there is no _host_build directory, but the etdump headers were successfully generated under pip-out/temp.*/cmake-out/sdk/include/executorch/sdk/etdump/.

Reviewed By: malfet, larryliu0820

Differential Revision: D56582507

Pulled By: dbort

fbshipit-source-id: 4ce6c680657bc57cfcf016826364a3f46c4c953e

Summary:
Currently, we always build two copies of the flatcc targets, just in case we happen to be cross-compiling. But because the flatcc project puts its binaries in the source directory, those two copies can interfere with each other.

We don't need to build two copies when not cross-compiling, so add a new option to avoid the second "host" build.

Eventually we should only enable this when cross-compiling, but for now disable it when building the pip package (which is never cross-compiled).

Pull Request resolved: pytorch#3356

Test Plan: `rm -rf pip-out && ./install_requirements.sh` succeeded. Looking in the `pip-out/temp.*/cmake-out` directory, there is no `_host_build` directory, but the etdump headers were successfully generated under `pip-out/temp.*/cmake-out/sdk/include/executorch/sdk/etdump/`.

Reviewed By: malfet, larryliu0820

Differential Revision: D56582507

Pulled By: dbort

fbshipit-source-id: 4ce6c680657bc57cfcf016826364a3f46c4c953e
Copy link

pytorch-bot bot commented Apr 25, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/3357

Note: Links to docs will display an error until the docs builds have been completed.

❌ 6 New Failures

As of commit 926d70e with merge base d3326a2 (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 25, 2024
@dbort dbort mentioned this pull request Apr 25, 2024
@mergennachin mergennachin self-requested a review April 25, 2024 19:29
@dbort dbort merged commit 517e697 into pytorch:release/0.2 Apr 25, 2024
78 of 84 checks passed
@dbort dbort deleted the pick-flatcc-host branch April 25, 2024 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants