Add EXECUTORCH_SEPARATE_FLATCC_HOST_PROJECT cmake option (#3356) #3357
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Currently, we always build two copies of the flatcc targets, just in case we happen to be cross-compiling. But because the flatcc project puts its binaries in the source directory, those two copies can interfere with each other.
We don't need to build two copies when not cross-compiling, so add a new option to avoid the second "host" build.
Eventually we should only enable this when cross-compiling, but for now disable it when building the pip package (which is never cross-compiled).
Pull Request resolved: #3356
Test Plan:
rm -rf pip-out && ./install_requirements.sh
succeeded. Looking in thepip-out/temp.*/cmake-out
directory, there is no_host_build
directory, but the etdump headers were successfully generated underpip-out/temp.*/cmake-out/sdk/include/executorch/sdk/etdump/
.Reviewed By: malfet, larryliu0820
Differential Revision: D56582507
Pulled By: dbort
fbshipit-source-id: 4ce6c680657bc57cfcf016826364a3f46c4c953e