Skip to content

Export the ET_VERSION_DOCS variable in doc build #3358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Export the ET_VERSION_DOCS variable in doc build #3358

wants to merge 1 commit into from

Conversation

svekars
Copy link
Contributor

@svekars svekars commented Apr 25, 2024

No description provided.

@svekars svekars requested a review from dbort April 25, 2024 18:15
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Apr 25, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/3358

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 71ac828 with merge base 80d72f2 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 25, 2024
@facebook-github-bot
Copy link
Contributor

@svekars has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

dbort
dbort approved these changes Apr 25, 2024
View reviewed changes
Copy link
Contributor

@dbort dbort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, if this var needs to be visible by the commands that make runs.

@svekars
Copy link
Contributor Author

svekars commented Apr 25, 2024

@pytorchbot cherry-pick --onto release/0.2 -c docs

@facebook-github-bot
Copy link
Contributor

@svekars merged this pull request in c32b0a2.

@svekars
Copy link
Contributor Author

svekars commented Apr 25, 2024

@pytorchbot cherry-pick --onto release/0.2 -c docs

pytorchbot pushed a commit that referenced this pull request Apr 25, 2024
@svekars @pytorchbot
Export the ET_VERSION_DOCS variable in doc build (#3358)
f072205 
Summary: Pull Request resolved: #3358

Reviewed By: dbort

Differential Revision: D56584847

Pulled By: svekars

fbshipit-source-id: 77c4105edf15503bf1b29c1f120111a73b973c4c
(cherry picked from commit c32b0a2)
@pytorchbot
Copy link
Collaborator

Cherry picking #3358

The cherry pick PR is at #3359

Details for Dev Infra team Raised by workflow job

@svekars svekars mentioned this pull request Apr 25, 2024
Closed
mergennachin pushed a commit that referenced this pull request Apr 25, 2024
@svekars @mergennachin
Export the ET_VERSION_DOCS variable in doc build (#3358)
f9aa51c 
Summary: Pull Request resolved: #3358

Reviewed By: dbort

Differential Revision: D56584847

Pulled By: svekars

fbshipit-source-id: 77c4105edf15503bf1b29c1f120111a73b973c4c
(cherry picked from commit c32b0a2)
@mergennachin mergennachin mentioned this pull request Apr 26, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbort dbort dbort approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@svekars @facebook-github-bot @pytorchbot @dbort