Simplify SDK tutorial by moving cmake commands to a script #3438
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/3438
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit dfc11cf with merge base 41eec7a ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
@Olivia-liu has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@Olivia-liu has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Jack-Khuu
approved these changes
May 1, 2024
|
@Olivia-liu merged this pull request in a4ffd96. |
|
@pytorchbot cherry-pick --onto release/0.2 -c docs |
Cherry picking #3438The cherry pick PR is at #3492 Details for Dev Infra teamRaised by workflow job |
Gasoonjia
pushed a commit
that referenced
this pull request
Jun 5, 2024
…3492) Summary: As titled. Tested the commands on mac locally and they worked. Pull Request resolved: #3438 Reviewed By: Jack-Khuu Differential Revision: D56792240 Pulled By: Olivia-liu fbshipit-source-id: dd62ea2fc788c5e1867d1e50037d7b4fd7e3a3f9 (cherry picked from commit a4ffd96) Co-authored-by: Olivia Liu <[email protected]> Co-authored-by: Peixuan Liu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address this comment. Tested the commands on mac locally and they worked. The script just generates etdump when working properly. I did "ls -l etdump.etdp" to check the timestamp.