Skip to content

Use compile-time promotion to reduce remainder size & build time #3458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

Use compile-time promotion to reduce remainder size & build time #3458

wants to merge 3 commits into from

Conversation

swolchok
Copy link
Contributor

@swolchok swolchok commented May 1, 2024

Summary: Yet another op that can benefit from compile-time type promotion.

Differential Revision: D56831293

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented May 1, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/3458

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 1 Unrelated Failure

As of commit 34a51bc with merge base 37d65a9 (image):

NEW FAILURE - The following job has failed:

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 1, 2024
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D56831293

swolchok added a commit to swolchok/executorch that referenced this pull request May 1, 2024
@swolchok @facebook-github-bot
Use compile-time promotion to reduce remainder size & build time (pyt…
5bed826 
…orch#3458)

Summary:
Pull Request resolved: pytorch#3458

Yet another op that can benefit from compile-time type promotion.

Differential Revision: D56831293
@swolchok swolchok force-pushed the export-D56831293 branch from fe3bed8 to 5bed826 Compare May 1, 2024 21:54
swolchok added a commit to swolchok/executorch that referenced this pull request May 2, 2024
@swolchok @facebook-github-bot
Use compile-time promotion to reduce remainder size & build time (pyt…
7dcbeed 
…orch#3458)

Summary:
Pull Request resolved: pytorch#3458

Yet another op that can benefit from compile-time type promotion.

Differential Revision: D56831293
@swolchok swolchok force-pushed the export-D56831293 branch 2 times, most recently from 7dcbeed to 143eeca Compare May 2, 2024 17:04
swolchok added a commit to swolchok/executorch that referenced this pull request May 2, 2024
@swolchok @facebook-github-bot
Use compile-time promotion to reduce remainder size & build time (pyt…
143eeca 
…orch#3458)

Summary:
Pull Request resolved: pytorch#3458

Yet another op that can benefit from compile-time type promotion.

Differential Revision: D56831293
swolchok added a commit to swolchok/executorch that referenced this pull request May 3, 2024
@swolchok @facebook-github-bot
Use compile-time promotion to reduce remainder size & build time (pyt…
199d6d1 
…orch#3458)

Summary:

Yet another op that can benefit from compile-time type promotion.

Differential Revision: D56831293
@swolchok swolchok force-pushed the export-D56831293 branch from 143eeca to 199d6d1 Compare May 3, 2024 17:26
swolchok added a commit to swolchok/executorch that referenced this pull request May 7, 2024
@swolchok @facebook-github-bot
Use compile-time promotion to reduce remainder size & build time (pyt…
de98ec5 
…orch#3458)

Summary:

Yet another op that can benefit from compile-time type promotion.

Reviewed By: manuelcandales

Differential Revision: D56831293
swolchok added a commit to swolchok/executorch that referenced this pull request May 7, 2024
@swolchok @facebook-github-bot
Use compile-time promotion to reduce remainder size & build time (pyt…
3bf7dda 
…orch#3458)

Summary:

Yet another op that can benefit from compile-time type promotion.

Reviewed By: manuelcandales

Differential Revision: D56831293
swolchok added a commit to swolchok/executorch that referenced this pull request May 7, 2024
@swolchok @facebook-github-bot
Use compile-time promotion to reduce remainder size & build time (pyt…
057b133 
…orch#3458)

Summary:

Yet another op that can benefit from compile-time type promotion.

Reviewed By: manuelcandales

Differential Revision: D56831293
swolchok added a commit to swolchok/executorch that referenced this pull request May 7, 2024
@swolchok @facebook-github-bot
Use compile-time promotion to reduce remainder size & build time (pyt…
bdd3066 
…orch#3458)

Summary:

Yet another op that can benefit from compile-time type promotion.

Reviewed By: manuelcandales

Differential Revision: D56831293
swolchok added a commit to swolchok/executorch that referenced this pull request May 7, 2024
@swolchok @facebook-github-bot
Use compile-time promotion to reduce remainder size & build time (pyt…
f2ef5a4 
…orch#3458)

Summary:

Yet another op that can benefit from compile-time type promotion.

Reviewed By: manuelcandales

Differential Revision: D56831293
swolchok added a commit to swolchok/executorch that referenced this pull request May 7, 2024
@swolchok @facebook-github-bot
Use compile-time promotion to reduce remainder size & build time (pyt…
7a473f8 
…orch#3458)

Summary:

Yet another op that can benefit from compile-time type promotion.

Reviewed By: manuelcandales

Differential Revision: D56831293
swolchok added a commit to swolchok/executorch that referenced this pull request May 7, 2024
@swolchok @facebook-github-bot
Use compile-time promotion to reduce remainder size & build time (pyt…
21430d2 
…orch#3458)

Summary:

Yet another op that can benefit from compile-time type promotion.

Reviewed By: manuelcandales

Differential Revision: D56831293
swolchok added a commit to swolchok/executorch that referenced this pull request May 7, 2024
@swolchok @facebook-github-bot
Use compile-time promotion to reduce remainder size & build time (pyt…
e4722a7 
…orch#3458)

Summary:

Yet another op that can benefit from compile-time type promotion.

Reviewed By: manuelcandales

Differential Revision: D56831293
swolchok added a commit to swolchok/executorch that referenced this pull request May 7, 2024
@swolchok @facebook-github-bot
Use compile-time promotion to reduce remainder size & build time (pyt…
ddc0799 
…orch#3458)

Summary:

Yet another op that can benefit from compile-time type promotion.

Reviewed By: manuelcandales

Differential Revision: D56831293
swolchok added a commit to swolchok/executorch that referenced this pull request May 8, 2024
@swolchok @facebook-github-bot
Use compile-time promotion to reduce remainder size & build time (pyt…
70ffeb2 
…orch#3458)

Summary:

Yet another op that can benefit from compile-time type promotion.

Reviewed By: manuelcandales

Differential Revision: D56831293
swolchok added a commit to swolchok/executorch that referenced this pull request May 8, 2024
@swolchok @facebook-github-bot
Use compile-time promotion to reduce remainder size & build time (pyt…
1bbe575 
…orch#3458)

Summary:

Yet another op that can benefit from compile-time type promotion.

Reviewed By: manuelcandales

Differential Revision: D56831293
@swolchok swolchok force-pushed the export-D56831293 branch from 199d6d1 to ccb58e3 Compare May 8, 2024 18:25
swolchok added a commit to swolchok/executorch that referenced this pull request May 8, 2024
@swolchok @facebook-github-bot
Use compile-time promotion to reduce remainder size & build time (pyt…
5e8e45b 
…orch#3458)

Summary:

Yet another op that can benefit from compile-time type promotion.

Reviewed By: manuelcandales

Differential Revision: D56831293
swolchok added a commit to swolchok/executorch that referenced this pull request May 8, 2024
@swolchok @facebook-github-bot
Use compile-time promotion to reduce remainder size & build time (pyt…
f2668fa 
…orch#3458)

Summary:

Yet another op that can benefit from compile-time type promotion.

Reviewed By: manuelcandales

Differential Revision: D56831293
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D56831293

swolchok added a commit to swolchok/executorch that referenced this pull request May 8, 2024
@swolchok @facebook-github-bot
Use compile-time promotion to reduce remainder size & build time (pyt…
535dcc2 
…orch#3458)

Summary:

Yet another op that can benefit from compile-time type promotion.

Reviewed By: manuelcandales

Differential Revision: D56831293
@swolchok swolchok force-pushed the export-D56831293 branch from ccb58e3 to 535dcc2 Compare May 8, 2024 18:26
swolchok added 3 commits May 8, 2024 13:48
@swolchok @facebook-github-bot
Use compile-time promotion to reduce max/min size & build time (pytor…
5077dc9 
…ch#3459)

Summary:

Yet another smaller pair of ops.

Reviewed By: manuelcandales

Differential Revision: D56807402
@swolchok @facebook-github-bot
Use compile-time promotion to reduce floor_divide size & build time (p…
1d19466 
…ytorch#3455)

Summary:

Continuing rollout of this technique.

Reviewed By: manuelcandales

Differential Revision: D56827786
@swolchok @facebook-github-bot
Use compile-time promotion to reduce remainder size & build time (pyt…
34a51bc 
…orch#3458)

Summary:

Yet another op that can benefit from compile-time type promotion.

Reviewed By: manuelcandales

Differential Revision: D56831293
@swolchok swolchok force-pushed the export-D56831293 branch from 535dcc2 to 34a51bc Compare May 8, 2024 20:48
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D56831293

@facebook-github-bot
Copy link
Contributor

This pull request has been merged in ad33982.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manuelcandales manuelcandales manuelcandales approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@swolchok @facebook-github-bot @manuelcandales