Skip to content

[Release Only][pyproject.toml] Also pin torchvision and torchaudio #3787

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 31, 2024

Conversation

huydhn
Copy link
Contributor

@huydhn huydhn commented May 31, 2024

T186838701, the CI already build torch and all domain libraries (vision, audio) from scratch using pinned commits, but having torch==2.3 in pyproject.toml overwrites torch installation with 2.3 release.

I think this is a consistent way to fix the issue because:

  • Vision and audio are needed in some cases
  • Vision and audio need to be compatible with the torch version to work. Assuming that someone install executorch 0.2 which will overwrite their local torch installation, they would also need the corresponding vision and audio. If they have an existing installation of vision/audio around, it would likely fail
  • It's a simple fix

The con is that install executorch 0.2 will always install torch, vision, and audio. However, that might not be that bad because that's how the installation instruction on https://pytorch.org/get-started/locally/ says anyway.

Copy link

pytorch-bot bot commented May 31, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/3787

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

❌ 1 New Failure

As of commit b09052f with merge base d3326a2 (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 31, 2024
@huydhn
Copy link
Contributor Author

huydhn commented May 31, 2024

The issue looks fixed, there is one remaining macOS failure but it seems like another pre-existing failure in the release branch. So, I'll merge this change now.

@huydhn huydhn merged commit 8d6f7fb into release/0.2 May 31, 2024
83 of 84 checks passed
@huydhn huydhn deleted the forward-fix-3277 branch August 13, 2024 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants