Skip to content

[0.2.1 Release] Update third-party/pytorch to 2.3.1 rc #3789

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 6, 2024

Conversation

mcr229
Copy link
Contributor

@mcr229 mcr229 commented May 31, 2024

Update third-party/pytorch to the RC for PyTorch 2.3.1

Copy link

pytorch-bot bot commented May 31, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/3789

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit b9f1754 with merge base d3326a2 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 31, 2024
@mcr229 mcr229 requested review from mergennachin and guangy10 May 31, 2024 17:08
@mcr229 mcr229 mentioned this pull request May 31, 2024
@mergennachin
Copy link
Contributor

what git hash did you use for the new git submodule?

@mcr229
Copy link
Contributor Author

mcr229 commented May 31, 2024

@mergennachin I checked out the latest commit of release/2.3 branch which is 63d5e9221bedd1546b7d364b5ce4171547db12a9

https://github.com/pytorch/pytorch/commits/release/2.3/

@guangy10
Copy link
Contributor

FYI, the prebuilt binary version should be updated to 2.3.1 as well: https://github.com/pytorch/executorch/blob/release/0.2/install_requirements.sh#L66
Maybe you plan to do it in a separate PR?

@guangy10
Copy link
Contributor

FYI, the prebuilt binary version should be updated to 2.3.1 as well: https://github.com/pytorch/executorch/blob/release/0.2/install_requirements.sh#L66 Maybe you plan to do it in a separate PR?

I think you may want to use the commit hash that v2.3.1-rc3 tag sits: https://github.com/pytorch/pytorch/tree/v2.3.1-rc3

@mcr229
Copy link
Contributor Author

mcr229 commented May 31, 2024

FYI, the prebuilt binary version should be updated to 2.3.1 as well: https://github.com/pytorch/executorch/blob/release/0.2/install_requirements.sh#L66 Maybe you plan to do it in a separate PR?

I had a pr that did this update but failed because 2.3.1 was not a real branch, since it reuses the 2.3.0 branch. Which is why I refrained from making these changes.

@mergennachin
Copy link
Contributor

@mcr229

I had a pr that did this update but failed because 2.3.1 was not a real branch, since it reuses the 2.3.0 branch. Which is why I refrained from making these changes.

I think there are two separate things. There's a pin that uses a release branch to check out PT and build. It is used in CI. I think your previous PR tried to change that.

What @guangy10 is mentioning is the install_requirements.sh script that developers use to install and setup executorch. That needs to be updated.

@mcr229
Copy link
Contributor Author

mcr229 commented Jun 3, 2024

@mergennachin @guangy10
Sounds good, I updated the third-party/pytorch commit to the tag v2.3.1-rc3 by

cd third-party/pytorch
git checkout tags/v2.3.1-rc3  

I also updated the install requirements to the patched releases.

dbort
dbort previously requested changes Jun 4, 2024
Copy link
Contributor

@dbort dbort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually could you also update the versions in

"torch==2.3",
"torchvision==0.18",
"torchaudio==2.3",
so that the pip package uses these versions, too?

@mcr229 mcr229 added the ciflow/binaries/all Release PRs with this label will build wheels for all python versions label Jun 5, 2024
@mergennachin mergennachin requested a review from dbort June 6, 2024 15:25
@mergennachin mergennachin dismissed dbort’s stale review June 6, 2024 15:29

Already addressed.

@mergennachin mergennachin merged commit 53ca076 into release/0.2 Jun 6, 2024
89 checks passed
@mcr229 mcr229 deleted the update-0.2.1 branch March 24, 2025 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/binaries/all Release PRs with this label will build wheels for all python versions ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants