-
Notifications
You must be signed in to change notification settings - Fork 537
[0.2.1 Release] Update third-party/pytorch to 2.3.1 rc #3789
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/3789
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit b9f1754 with merge base d3326a2 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
what git hash did you use for the new git submodule? |
@mergennachin I checked out the latest commit of release/2.3 branch which is 63d5e9221bedd1546b7d364b5ce4171547db12a9 https://github.com/pytorch/pytorch/commits/release/2.3/ |
FYI, the prebuilt binary version should be updated to 2.3.1 as well: https://github.com/pytorch/executorch/blob/release/0.2/install_requirements.sh#L66 |
I think you may want to use the commit hash that v2.3.1-rc3 tag sits: https://github.com/pytorch/pytorch/tree/v2.3.1-rc3 |
I had a pr that did this update but failed because 2.3.1 was not a real branch, since it reuses the 2.3.0 branch. Which is why I refrained from making these changes. |
I think there are two separate things. There's a pin that uses a release branch to check out PT and build. It is used in CI. I think your previous PR tried to change that. What @guangy10 is mentioning is the install_requirements.sh script that developers use to install and setup executorch. That needs to be updated. |
@mergennachin @guangy10
I also updated the install requirements to the patched releases. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually could you also update the versions in
Lines 63 to 65 in d16aaa5
"torch==2.3", | |
"torchvision==0.18", | |
"torchaudio==2.3", |
Update third-party/pytorch to the RC for PyTorch 2.3.1