Skip to content

Update quant overview for 021 #3845

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Conversation

Jack-Khuu
Copy link
Contributor

No description provided.

Copy link

pytorch-bot bot commented Jun 5, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/3845

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure

As of commit be9b90c with merge base f184329 (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 5, 2024
@Jack-Khuu Jack-Khuu requested review from lucylq and jerryzh168 June 5, 2024 07:16
@facebook-github-bot
Copy link
Contributor

@Jack-Khuu has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

```
from torchao.quantization.quant_api import Int8DynActInt4WeightQuantizer

model = Int8DynActInt4WeightQuantizer(precision=torch_dtype, groupsize=group_size).quantize(model)
Copy link
Contributor

@jerryzh168 jerryzh168 Jun 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: do we want to quickly mentioned how it's lowered as well, so people can have a more concrete picture of when the quantization happens

Copy link
Contributor

@jerryzh168 jerryzh168 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left one comment

@facebook-github-bot
Copy link
Contributor

@Jack-Khuu has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@Jack-Khuu merged this pull request in f48f392.

@Jack-Khuu
Copy link
Contributor Author

@pytorchbot cherry-pick --onto release/0.2 -c docs

pytorchbot pushed a commit that referenced this pull request Jun 5, 2024
Summary: Pull Request resolved: #3845

Reviewed By: Gasoonjia

Differential Revision: D58176137

Pulled By: Jack-Khuu

fbshipit-source-id: bdaf01a8fb66ba3333c3b6d7802c3bb02b20c4a5
(cherry picked from commit f48f392)
@pytorchbot
Copy link
Collaborator

Cherry picking #3845

The cherry pick PR is at #3857

Details for Dev Infra team Raised by workflow job

Gasoonjia pushed a commit that referenced this pull request Jun 5, 2024
Summary: Pull Request resolved: #3845

Reviewed By: Gasoonjia

Differential Revision: D58176137

Pulled By: Jack-Khuu

fbshipit-source-id: bdaf01a8fb66ba3333c3b6d7802c3bb02b20c4a5
(cherry picked from commit f48f392)

Co-authored-by: Jack-Khuu <[email protected]>
@Jack-Khuu Jack-Khuu deleted the update-quant-overview-for-021 branch October 2, 2024 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants