Skip to content

[ET-VK] Move gen_vulkan_spv.py out of api/ #4121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

[ET-VK] Move gen_vulkan_spv.py out of api/ #4121

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d0e25cc
[ET-VK] Move `gen_vulkan_spv.py` out of `api/`
Jul 2, 2024
b01b768
Update on "[ET-VK] Move `gen_vulkan_spv.py` out of `api/`"
Jul 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions backends/vulkan/cmake/ShaderLibrary.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ function(gen_vulkan_shader_lib_cpp shaders_path)
execute_process(
COMMAND
"${PYTHON_EXECUTABLE}"
${EXECUTORCH_ROOT}/backends/vulkan/runtime/api/gen_vulkan_spv.py
${EXECUTORCH_ROOT}/backends/vulkan/runtime/gen_vulkan_spv.py
--glsl-path ${shaders_path} --output-path ${VULKAN_SHADERGEN_OUT_PATH}
--glslc-path=${GLSLC_PATH} --tmp-dir-path=${VULKAN_SHADERGEN_OUT_PATH}
--env ${VULKAN_GEN_ARG_ENV}
Expand Down Expand Up @@ -87,7 +87,7 @@ macro(vulkan_shader_library shaders_path library_name)
set(VULKAN_SHADERGEN_OUT_PATH ${CMAKE_BINARY_DIR}/${library_name})

# execute_process( COMMAND "${PYTHON_EXECUTABLE}"
# ${EXECUTORCH_ROOT}/backends/vulkan/runtime/api/gen_vulkan_spv.py --glsl-path
# ${EXECUTORCH_ROOT}/backends/vulkan/runtime/gen_vulkan_spv.py --glsl-path
# ${shaders_path} --output-path ${VULKAN_SHADERGEN_OUT_PATH}
# --glslc-path=${GLSLC_PATH} --tmp-dir-path=${VULKAN_SHADERGEN_OUT_PATH} --env
# ${VULKAN_GEN_ARG_ENV} RESULT_VARIABLE error_code ) set(ENV{PYTHONPATH}
Expand Down
0 ...ends/vulkan/runtime/api/gen_vulkan_spv.py → backends/vulkan/runtime/gen_vulkan_spv.py
View file
Open in desktop
File renamed without changes.
4 changes: 2 additions & 2 deletions backends/vulkan/targets.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,15 +56,15 @@ def define_common_targets(is_fbcode = False):
runtime.python_library(
name = "gen_vulkan_spv_lib",
srcs = [
"runtime/api/gen_vulkan_spv.py",
"runtime/gen_vulkan_spv.py",
],
base_module = "",
external_deps = ["torchgen"],
)

runtime.python_binary(
name = "gen_vulkan_spv_bin",
main_module = "runtime.api.gen_vulkan_spv",
main_module = "runtime.gen_vulkan_spv",
visibility = [
"//executorch/backends/vulkan/...",
"@EXECUTORCH_CLIENTS",
Expand Down