[ET-VK] Move files using the Vulkan API to vk_api/
#4125
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and move from namespace `api` to `vkapi`. This gave me a major headache in the number of places to update. This stack orgnaizes ET-VK neatly into three abstraction levels, both by folder and by namespace: 1. `namespace vkcompute` and `graph/`: for operator computation implementation and scheduling. 2. `namespace vkcompute::api` and `graph/api/`: for tensor objects (and other objects wrapping our VulkanBuffer/VulkanImage). 3. `namespace vkcompute::vkapi` and `graph/api/vk_api/`: for direct users of Vulkan API Additionally, we have - `namespace vkcompute::utils` and `graph/api/utils/`: for utils used by both namespace `api` and `vkapi` Differential Revision: [D59281539](https://our.internmc.facebook.com/intern/diff/D59281539/) [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/4125
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New Failure, 1 Unrelated FailureAs of commit 7828080 with merge base c839b9e ( NEW FAILURE - The following job has failed:
BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
pytorch-bot
bot
added
ciflow/periodic
module: vulkan
|
Warning: Unknown label
Please add the new label to .github/pytorch-probot.yml |
facebook-github-bot
added
the
CLA Signed
This was referenced Jul 2, 2024
|
This pull request was exported from Phabricator. Differential Revision: D59281539 |
This was referenced Jul 2, 2024
junpi3
pushed a commit
that referenced
this pull request
Jul 2, 2024
and move from namespace `api` to `vkapi`. This gave me a major headache in the number of places to update. This stack orgnaizes ET-VK neatly into three abstraction levels, both by folder and by namespace: 1. `namespace vkcompute` and `graph/`: for operator computation implementation and scheduling. 2. `namespace vkcompute::api` and `graph/api/`: for tensor objects (and other objects wrapping our VulkanBuffer/VulkanImage). 3. `namespace vkcompute::vkapi` and `graph/api/vk_api/`: for direct users of Vulkan API Additionally, we have - `namespace vkcompute::utils` and `graph/api/utils/`: for utils used by both namespace `api` and `vkapi` Differential Revision: [D59281539](https://our.internmc.facebook.com/intern/diff/D59281539/) ghstack-source-id: 232319222 Pull Request resolved: #4125
SS-JIA
approved these changes
Jul 2, 2024
and move from namespace `api` to `vkapi`. This gave me a major headache in the number of places to update. This stack orgnaizes ET-VK neatly into three abstraction levels, both by folder and by namespace: 1. `namespace vkcompute` and `graph/`: for operator computation implementation and scheduling. 2. `namespace vkcompute::api` and `graph/api/`: for tensor objects (and other objects wrapping our VulkanBuffer/VulkanImage). 3. `namespace vkcompute::vkapi` and `graph/api/vk_api/`: for direct users of Vulkan API Additionally, we have - `namespace vkcompute::utils` and `graph/api/utils/`: for utils used by both namespace `api` and `vkapi` Differential Revision: [D59281539](https://our.internmc.facebook.com/intern/diff/D59281539/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D59281539 |
and move from namespace `api` to `vkapi`. This gave me a major headache in the number of places to update. This stack orgnaizes ET-VK neatly into three abstraction levels, both by folder and by namespace: 1. `namespace vkcompute` and `graph/`: for operator computation implementation and scheduling. 2. `namespace vkcompute::api` and `graph/api/`: for tensor objects (and other objects wrapping our VulkanBuffer/VulkanImage). 3. `namespace vkcompute::vkapi` and `graph/api/vk_api/`: for direct users of Vulkan API Additionally, we have - `namespace vkcompute::utils` and `graph/api/utils/`: for utils used by both namespace `api` and `vkapi` Differential Revision: [D59281539](https://our.internmc.facebook.com/intern/diff/D59281539/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D59281539 |
|
This pull request has been merged in 17bab7d. |
kedarnath03
pushed a commit
to kedarnath03/executorch
that referenced
this pull request
Jun 25, 2025
Pull Request resolved: pytorch/executorch#4125 and move from namespace `api` to `vkapi`. This gave me a major headache in the number of places to update. This stack orgnaizes ET-VK neatly into three abstraction levels, both by folder and by namespace: 1. `namespace vkcompute` and `graph/`: for operator computation implementation and scheduling. 2. `namespace vkcompute::api` and `graph/api/`: for tensor objects (and other objects wrapping our VulkanBuffer/VulkanImage). 3. `namespace vkcompute::vkapi` and `graph/api/vk_api/`: for direct users of Vulkan API Additionally, we have - `namespace vkcompute::utils` and `graph/api/utils/`: for utils used by both namespace `api` and `vkapi` ghstack-source-id: 232399401 @exported-using-ghexport Differential Revision: [D59281539](https://our.internmc.facebook.com/intern/diff/D59281539/)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
vk_api/#4125and move from namespace
apitovkapi. This gave me a major headache in the number of places to update.This stack orgnaizes ET-VK neatly into three abstraction levels, both by folder and by namespace:
namespace vkcomputeandgraph/: for operator computation implementation and scheduling.namespace vkcompute::apiandgraph/api/: for tensor objects (and other objects wrapping our VulkanBuffer/VulkanImage).namespace vkcompute::vkapiandgraph/api/vk_api/: for direct users of Vulkan APIAdditionally, we have
namespace vkcompute::utilsandgraph/api/utils/: for utils used by both namespaceapiandvkapiDifferential Revision: D59281539