Skip to content

[ET-VK] Order stdlib includes after ET includes #4127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions backends/vulkan/runtime/api/utils/VecUtils.h
Original file line number Diff line number Diff line change
Expand Up @@ -8,15 +8,15 @@

#pragma once

#include <executorch/backends/vulkan/runtime/api/vk_api/vk_api.h>

#include <executorch/backends/vulkan/runtime/api/vk_api/Exception.h>

#include <cmath>
#include <limits>
#include <numeric>
#include <type_traits>

#include <executorch/backends/vulkan/runtime/api/vk_api/vk_api.h>

#include <executorch/backends/vulkan/runtime/api/vk_api/Exception.h>

namespace vkcompute {
namespace utils {

Expand Down
6 changes: 3 additions & 3 deletions backends/vulkan/runtime/api/vk_api/QueryPool.h
Original file line number Diff line number Diff line change
Expand Up @@ -10,15 +10,15 @@

// @lint-ignore-every CLANGTIDY facebook-hte-BadMemberName

#include <cstdint>
#include <functional>

#include <executorch/backends/vulkan/runtime/api/vk_api/vk_api.h>

#include <executorch/backends/vulkan/runtime/api/vk_api/Adapter.h>
#include <executorch/backends/vulkan/runtime/api/vk_api/Command.h>
#include <executorch/backends/vulkan/runtime/api/vk_api/Pipeline.h>

#include <cstdint>
#include <functional>

#ifndef VULKAN_QUERY_POOL_SIZE
#define VULKAN_QUERY_POOL_SIZE 4096u
#endif
Expand Down
7 changes: 4 additions & 3 deletions backends/vulkan/runtime/api/vk_api/Runtime.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -6,13 +6,14 @@
* LICENSE file in the root directory of this source tree.
*/

#include <executorch/backends/vulkan/runtime/api/vk_api/Runtime.h>

#include <executorch/backends/vulkan/runtime/api/vk_api/Adapter.h>

#include <cstring>
#include <iostream>
#include <sstream>

#include <executorch/backends/vulkan/runtime/api/vk_api/Adapter.h>
#include <executorch/backends/vulkan/runtime/api/vk_api/Runtime.h>

namespace vkcompute {
namespace vkapi {

Expand Down
6 changes: 3 additions & 3 deletions backends/vulkan/runtime/api/vk_api/Runtime.h
Original file line number Diff line number Diff line change
Expand Up @@ -10,13 +10,13 @@

// @lint-ignore-every CLANGTIDY facebook-hte-BadMemberName

#include <functional>
#include <memory>

#include <executorch/backends/vulkan/runtime/api/vk_api/vk_api.h>

#include <executorch/backends/vulkan/runtime/api/vk_api/Adapter.h>

#include <functional>
#include <memory>

namespace vkcompute {
namespace vkapi {

Expand Down
4 changes: 2 additions & 2 deletions backends/vulkan/runtime/api/vk_api/Shader.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -6,10 +6,10 @@
* LICENSE file in the root directory of this source tree.
*/

#include <utility>

#include <executorch/backends/vulkan/runtime/api/vk_api/Shader.h>

#include <utility>

namespace vkcompute {
namespace vkapi {

Expand Down
6 changes: 3 additions & 3 deletions backends/vulkan/runtime/api/vk_api/Types.h
Original file line number Diff line number Diff line change
Expand Up @@ -10,13 +10,13 @@

// @lint-ignore-every CLANGTIDY bugprone-branch-clone

#include <cstddef>
#include <cstdint>

#include <executorch/backends/vulkan/runtime/api/vk_api/vk_api.h>

#include <executorch/backends/vulkan/runtime/api/vk_api/Exception.h>

#include <cstddef>
#include <cstdint>

#ifdef USE_VULKAN_FP16_INFERENCE
#define VK_FORMAT_FLOAT4 VK_FORMAT_R16G16B16A16_SFLOAT
#else
Expand Down
Loading