Skip to content

[Build] Set correct flatcc path for Windows #4993

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

python3kgae
Copy link
Contributor

The binary directory for Windows will have build type like Debug/Release at the end.

For #4661

The binary directory for Windows will have build type like Debug/Release at the end.

For pytorch#4661
Copy link

pytorch-bot bot commented Aug 29, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/4993

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure

As of commit eec7e96 with merge base 959bb1b (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 29, 2024
@shoumikhin
Copy link
Contributor

@tarun292, @kirklandsign, @Gasoonjia can you take a look please?

@SS-JIA
Copy link
Contributor

SS-JIA commented Mar 17, 2025

The changes here are covered by #8970 already. I think we can close this PR.

@SS-JIA SS-JIA closed this Mar 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants