[Build] use timespec_get to get current time #5252
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/5252
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New FailureAs of commit 21094a9 with merge base 0342bab ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
@tarun292, @kirklandsign can you take a look please? |
|
@pytorchbot rebase |
Replace clock_gettime with timespec_get which works on Windows as well. For pytorch#4661
larryliu0820
force-pushed
the
timespec_get
branch
from
92bac8e to
176f197
Compare
larryliu0820
requested review from
jackzhxng,
iseeyuan,
larryliu0820 and
swolchok
as code owners
|
apparently timespec_get is only available in recent versions of Android. confluentinc/librdkafka#3044 |
swolchok
requested changes
Mar 17, 2025
Thanks for the feedback. |
swolchok
approved these changes
Mar 24, 2025
extension/llm/runner/util.h
Outdated
Comment on lines
72
to
73
| // above 29. | ||
| #if defined(__ANDROID_API__) && __ANDROID_API__ < 29 |
There was a problem hiding this comment.
comment doesn't match the code -- comment says above 29, code says 29 or later
|
Thank you! |
kirklandsign
pushed a commit
that referenced
this pull request
Apr 11, 2025
Replace clock_gettime with timespec_get which works on Windows as well. For #4661
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace clock_gettime with timespec_get which works on Windows as well.
For #4661