Skip to content

Update cmake docs to reflect the recommended way of running cmake #6329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 17, 2024

Conversation

larryliu0820
Copy link
Contributor

cmake

Summary: Update the library name and make the cmake command a bit better

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

Copy link

pytorch-bot bot commented Oct 17, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/6329

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure

As of commit 09a37e0 with merge base eecf74f (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 17, 2024
@larryliu0820 larryliu0820 changed the base branch from main to release/0.4 October 17, 2024 17:43
cmake

Summary: Update the library name and make the cmake command a bit better

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:
@larryliu0820 larryliu0820 changed the title Update cmake docs to reflect the latest recommended way of running Update cmake docs to reflect the recommended way of running cmake Oct 17, 2024
Copy link
Contributor

@jackzhxng jackzhxng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved pending @kirklandsign comment

Summary:

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:
@larryliu0820 larryliu0820 merged commit a5a147f into release/0.4 Oct 17, 2024
4 checks passed
@larryliu0820 larryliu0820 deleted the update_cmake_doc branch October 17, 2024 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants