Skip to content

upgrade lm_eval to 0.4.5 #6555

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

helunwencser
Copy link
Contributor

@helunwencser helunwencser commented Oct 29, 2024

We have been using a pretty old lm_eval version. This is blocking us from upgrading other libraries like transformers and blocking some others work. For example, #6489.

In newer versions lm_eval, pretrainedModel becomes a required parameter. In 0.4.2, it defaults to gpt2 if not provided. This PR upgrades our lm_eval version to the latest version 0.4.5 and set pretrainedModel to its original default value gpt2.

Test Plan:
Run eval before and after this PR. Make sure the perplexity number stays around the same.
Screenshot 2024-10-28 at 12 22 45 PM

Differential Revision: D65162734

[ghstack-poisoned]
@helunwencser
Copy link
Contributor Author

helunwencser commented Oct 29, 2024

Stack from ghstack (oldest at bottom):

Copy link

pytorch-bot bot commented Oct 29, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/6555

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 11a650e with merge base 2c32bf3 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

helunwencser added a commit that referenced this pull request Oct 29, 2024
ghstack-source-id: ea34312
ghstack-comment-id: 2445169575
Pull Request resolved: #6555
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 29, 2024
@helunwencser
Copy link
Contributor Author

@helunwencser has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants