update sccache to latest version #6837
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/6837
Note: Links to docs will display an error until the docs builds have been completed. ❗ 2 Active SEVsThere are 2 currently active SEVs. If your PR is affected, please view them below:
✅ No FailuresAs of commit bbee49c with merge base 5b4d9bb ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
wdvr
force-pushed
the
wdvr/sccache_update
branch
from
d2b5e99 to
bcc5828
Compare
huydhn
reviewed
Nov 15, 2024
.ci/docker/common/install_cache.sh
Outdated
| # Instead use lib and headers from OpenSSL1.1 installed in `install_openssl.sh`` | ||
| apt-get install -y cargo | ||
| echo "Checking out sccache repo" | ||
| if [ -n "$CUDA_VERSION" ]; then |
There was a problem hiding this comment.
I think we can just use upstream https://github.com/mozilla/sccache to keep it simple here as there is no CUDA
huydhn
approved these changes
Nov 15, 2024
There was a problem hiding this comment.
LGTM! We can just use https://github.com/mozilla/sccache here as there is not going to be any CUDA, so we won't need pytorch-fork sccache
wdvr
force-pushed
the
wdvr/sccache_update
branch
from
6f7a717 to
bbee49c
Compare
swolchok
added a commit
that referenced
this pull request
Nov 21, 2024
This reverts commit 7278519. Nightly macos wheel builds are failing to link; seeing if this fixes it after inspecting commits between last good build (https://github.com/pytorch/executorch/actions/runs/11891594679) and first bad build (https://github.com/pytorch/executorch/actions/runs/11912200383)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Update SCCache to the latest version
This is part of the effort to get rid of AWS IMDSv1 usage. Latest SCCache uses IMDSv2, which is what we migrate to here (similar to pytorch/pytorch#121323).
Test plan
Check if SCCache is used and auth works to the S3 bucket for builds