[executorch][passes] Add config and pass to tag constants for external file #7193
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…l file - Add config 'external_constants' to ExecutorchBackendConfig. - When set to True, run the 'external_constants_pass' - This tags all constants as external, and moves them into a separate buffer to be serialized outside of the PTE file. Note: users can write their own passes to tag weights to specific files / multiple files. TODO: write example pass and test for the case where we have two constant files. Differential Revision: [D66560903](https://our.internmc.facebook.com/intern/diff/D66560903/) [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7193
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ❌ 1 New FailureAs of commit 23713e7 with merge base b9db0a3 ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
This was referenced Dec 5, 2024
|
This pull request was exported from Phabricator. Differential Revision: D66560903 |
…for external file" - Add config 'external_constants' to ExecutorchBackendConfig. - When set to True, run the 'external_constants_pass' - This tags all constants as external, and moves them into a separate buffer to be serialized outside of the PTE file. Note: users can write their own passes to tag weights to specific files / multiple files. TODO: write example pass and test for the case where we have two constant files. Differential Revision: [D66560903](https://our.internmc.facebook.com/intern/diff/D66560903/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D66560903 |
JacobSzwejbka
approved these changes
Dec 7, 2024
…for external file" - Add config 'external_constants' to ExecutorchBackendConfig. - When set to True, run the 'external_constants_pass' - This tags all constants as external, and moves them into a separate buffer to be serialized outside of the PTE file. Note: users can write their own passes to tag weights to specific files / multiple files. TODO: write example pass and test for the case where we have two constant files. Differential Revision: [D66560903](https://our.internmc.facebook.com/intern/diff/D66560903/) [ghstack-poisoned]
lucylq
added a commit
that referenced
this pull request
Dec 7, 2024
…l file Pull Request resolved: #7193 - Add config 'external_constants' to ExecutorchBackendConfig. - When set to True, run the 'external_constants_pass' - This tags all constants as external, and moves them into a separate buffer to be serialized outside of the PTE file. Note: users can write their own passes to tag weights to specific files / multiple files. TODO: write example pass and test for the case where we have two constant files. ghstack-source-id: 257036011 Differential Revision: [D66560903](https://our.internmc.facebook.com/intern/diff/D66560903/)
|
This pull request was exported from Phabricator. Differential Revision: D66560903 |
This was referenced Dec 9, 2024
…for external file" - Add config 'external_constants' to ExecutorchBackendConfig. - When set to True, run the 'external_constants_pass' - This tags all constants as external, and moves them into a separate buffer to be serialized outside of the PTE file. Note: users can write their own passes to tag weights to specific files / multiple files. TODO: write example pass and test for the case where we have two constant files. Differential Revision: [D66560903](https://our.internmc.facebook.com/intern/diff/D66560903/) [ghstack-poisoned]
lucylq
added a commit
that referenced
this pull request
Dec 10, 2024
…l file Pull Request resolved: #7193 - Add config 'external_constants' to ExecutorchBackendConfig. - When set to True, run the 'external_constants_pass' - This tags all constants as external, and moves them into a separate buffer to be serialized outside of the PTE file. Note: users can write their own passes to tag weights to specific files / multiple files. TODO: write example pass and test for the case where we have two constant files. ghstack-source-id: 257349683 Differential Revision: [D66560903](https://our.internmc.facebook.com/intern/diff/D66560903/)
|
This pull request was exported from Phabricator. Differential Revision: D66560903 |
…for external file" - Add config 'external_constants' to ExecutorchBackendConfig. - When set to True, run the 'external_constants_pass' - This tags all constants as external, and moves them into a separate buffer to be serialized outside of the PTE file. Note: users can write their own passes to tag weights to specific files / multiple files. TODO: write example pass and test for the case where we have two constant files. Differential Revision: [D66560903](https://our.internmc.facebook.com/intern/diff/D66560903/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D66560903 |
lucylq
added a commit
that referenced
this pull request
Dec 10, 2024
…l file Pull Request resolved: #7193 - Add config 'external_constants' to ExecutorchBackendConfig. - When set to True, run the 'external_constants_pass' - This tags all constants as external, and moves them into a separate buffer to be serialized outside of the PTE file. Note: users can write their own passes to tag weights to specific files / multiple files. TODO: write example pass and test for the case where we have two constant files. ghstack-source-id: 257353873 Differential Revision: [D66560903](https://our.internmc.facebook.com/intern/diff/D66560903/)
facebook-github-bot
merged commit e6d1d54
into
gh/lucylq/20/base
43 of 46 checks passed
facebook-github-bot
temporarily deployed
to
cherry-pick-bot
GitHub Actions
Inactive
kirklandsign
pushed a commit
that referenced
this pull request
Dec 10, 2024
…l file Pull Request resolved: #7193 - Add config 'external_constants' to ExecutorchBackendConfig. - When set to True, run the 'external_constants_pass' - This tags all constants as external, and moves them into a separate buffer to be serialized outside of the PTE file. Note: users can write their own passes to tag weights to specific files / multiple files. TODO: write example pass and test for the case where we have two constant files. ghstack-source-id: 257353873 Differential Revision: [D66560903](https://our.internmc.facebook.com/intern/diff/D66560903/)
kirklandsign
pushed a commit
that referenced
this pull request
Dec 10, 2024
…l file Pull Request resolved: #7193 - Add config 'external_constants' to ExecutorchBackendConfig. - When set to True, run the 'external_constants_pass' - This tags all constants as external, and moves them into a separate buffer to be serialized outside of the PTE file. Note: users can write their own passes to tag weights to specific files / multiple files. TODO: write example pass and test for the case where we have two constant files. ghstack-source-id: 257353873 Differential Revision: [D66560903](https://our.internmc.facebook.com/intern/diff/D66560903/) Co-authored-by: lucylq <[email protected]>
This was referenced Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Note: users can write their own passes to tag weights to specific files / multiple files.
TODO: write example pass and test for the case where we have two constant files.
Differential Revision: D66560903