[DevX] Enable editable mode#7443
Merged
Merged
Conversation
Enable `pip install -e .` with local build flatc and custom ops AOT lib disabled.
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7443
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 5ce5766 with merge base ed15042 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
larryliu0820
added
the
release notes: build
iseeyuan
approved these changes
Dec 27, 2024
Contributor
|
In pip install without local, cmake build first and copy the binaries into site packages. If editable, for some reason there's no cmake build (CustomBuild), and InstallerBuildExt would error. One option is to refactor and combine CustomBuild and InstallerBuildExt. If there's flatc in the env, no need to build flatc. Custom ops can be disabled if it's not used. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Partially fixing #2871
Enable
pip install -e .with local build flatc and custom ops AOT lib disabled.Test plan