-
Notifications
You must be signed in to change notification settings - Fork 536
add begin/end to ExecuTorch pytree::arr #7653
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add begin/end to ExecuTorch pytree::arr #7653
Conversation
Allows use of range-for. Differential Revision: [D68166302](https://our.internmc.facebook.com/intern/diff/D68166302/) [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7653
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 245e9cb with merge base b362ab7 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This pull request was exported from Phabricator. Differential Revision: D68166302 |
Allows use of range-for. Differential Revision: [D68166302](https://our.internmc.facebook.com/intern/diff/D68166302/) [ghstack-poisoned]
This pull request was exported from Phabricator. Differential Revision: D68166302 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems ok, but please add some unit tests for this new functionality
Allows use of range-for. Differential Revision: [D68166302](https://our.internmc.facebook.com/intern/diff/D68166302/) [ghstack-poisoned]
This pull request was exported from Phabricator. Differential Revision: D68166302 |
Allows use of range-for. Differential Revision: [D68166302](https://our.internmc.facebook.com/intern/diff/D68166302/) [ghstack-poisoned]
This pull request was exported from Phabricator. Differential Revision: D68166302 |
Allows use of range-for. Differential Revision: [D68166302](https://our.internmc.facebook.com/intern/diff/D68166302/) [ghstack-poisoned]
This pull request was exported from Phabricator. Differential Revision: D68166302 |
Allows use of range-for. Differential Revision: [D68166302](https://our.internmc.facebook.com/intern/diff/D68166302/) [ghstack-poisoned]
This pull request was exported from Phabricator. Differential Revision: D68166302 |
Pull Request resolved: #7653 Allows use of range-for. ghstack-source-id: 265152271 @exported-using-ghexport Differential Revision: [D68166302](https://our.internmc.facebook.com/intern/diff/D68166302/) Co-authored-by: Github Executorch <[email protected]>
Stack from ghstack (oldest at bottom):
Allows use of range-for.
Differential Revision: D68166302