Skip to content

Upgrade numpy version requirement to 2.0 #7659

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

pytorchbot
Copy link
Collaborator

Upgrade numpy version requirement to

Summary:

1.21 is too old now. For 3.10 or above, we should be able to use 2.0.0

We are already on CoreMLTools 8.1, which is https://github.com/apple/coremltools/blob/8.1/reqs/build.pip

We had to upgrade to the latest transformers as well

(cherry picked from commit a7b5297)
Copy link

pytorch-bot bot commented Jan 14, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7659

Note: Links to docs will display an error until the docs builds have been completed.

❌ 3 New Failures

As of commit f779ad3 with merge base 9069017 (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 14, 2025
@mergennachin mergennachin requested a review from SS-JIA January 14, 2025 21:36
@digantdesai
Copy link
Contributor

Seems like Arm jobs are broken because tosa serialization library doesn't support numpy2.0 and has a recent bug fix. Let me try to upgrade this for ET.

digantdesai added a commit that referenced this pull request Jan 15, 2025
This is to pull in an upstream fix to unblock #7659
digantdesai added a commit that referenced this pull request Jan 16, 2025
This is to pull in an upstream fix to unblock #7659
@SS-JIA SS-JIA closed this Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants