Skip to content

Support Half/BFloat16 in glu #7824

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 23, 2025
Merged

Support Half/BFloat16 in glu #7824

merged 2 commits into from
Jan 23, 2025

Conversation

swolchok
Copy link
Contributor

Partial fix for #7748.

@swolchok
Update
75d76e9 
[ghstack-poisoned]
@swolchok
Copy link
Contributor Author

swolchok commented Jan 22, 2025 •
edited
Loading

Stack from ghstack (oldest at bottom):

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Jan 22, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7824

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure

As of commit 447b0ae with merge base 466d98f (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 22, 2025
swolchok added a commit that referenced this pull request Jan 22, 2025
@swolchok
Support Half/BFloat16 in glu
2aa6d3a 
Partial fix for #7748.

ghstack-source-id: b25fafc
ghstack-comment-id: 2605988746
Pull Request resolved: #7824
@swolchok swolchok requested a review from GregoryComer January 22, 2025 00:02
@swolchok swolchok added the release notes: ops & kernels Changes to the opset and any new / changed kernel implementations label Jan 22, 2025
manuelcandales
manuelcandales requested changes Jan 22, 2025
View reviewed changes
kernels/test/op_glu_test.cpp
@@ -128,6 +128,20 @@ TEST_F(OpGluOutTest, AllInputDoubleOutputSupport) {
#undef TEST_ENTRY
}

TEST_F(OpGluOutTest, AllInputHalfOutputSupport) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't testing when the inputs are Half/Bfloat16

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whoops! fixed

@swolchok
Update
447b0ae 
[ghstack-poisoned]
swolchok added a commit that referenced this pull request Jan 22, 2025
@swolchok
Support Half/BFloat16 in glu
6b8226b 
Partial fix for #7748.

ghstack-source-id: 071c657
ghstack-comment-id: 2605988746
Pull Request resolved: #7824
@swolchok swolchok merged commit d5ef631 into main Jan 23, 2025
44 of 45 checks passed
@swolchok swolchok deleted the gh/swolchok/165/head branch January 23, 2025 17:59
YIWENX14 pushed a commit that referenced this pull request Jan 28, 2025
@swolchok @YIWENX14
Support Half/BFloat16 in glu (#7824)
58054e3 
Partial fix for #7748.
zonglinpeng pushed a commit to zonglinpeng/executorch that referenced this pull request Jan 30, 2025
@swolchok
Support Half/BFloat16 in glu (pytorch#7824)
2bc93c0 
Partial fix for pytorch#7748.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manuelcandales manuelcandales manuelcandales approved these changes

@GregoryComer GregoryComer Awaiting requested review from GregoryComer

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. release notes: ops & kernels Changes to the opset and any new / changed kernel implementations
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@swolchok @manuelcandales @facebook-github-bot