Support Half/BFloat16 in prod operator #7857
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Stack from ghstack (oldest at bottom): |
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7857
Note: Links to docs will display an error until the docs builds have been completed. ⏳ No Failures, 5 PendingAs of commit 2737333 with merge base 2411c99 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
kimishpatel
reviewed
Jan 22, 2025
| } | ||
| Tensor self = tf.make({2, 3}, {1, 2, 3, 4, 5, 6}); | ||
| int64_t dim = 0; | ||
| bool keepdim = false; |
There was a problem hiding this comment.
has there been a test with keepdim=True?
There was a problem hiding this comment.
I don't know, but adding such a test would be out of scope for this change.
kimishpatel
approved these changes
Jan 22, 2025
swolchok
added
the
release notes: ops & kernels
swolchok
added a commit
that referenced
this pull request
Jan 23, 2025
* Coerce to true_ctype in tensor_factory (#7856) This should fix the problem where attempts to test bool are often wonky in OSS and fail UBSAN internally; it is undefined behavior to store a value other than 0 or 1 for type bool. * Support Half/BFloat16 in prod operator (#7857) Partial fix for #7748.
YIWENX14
pushed a commit
that referenced
this pull request
Jan 28, 2025
* Coerce to true_ctype in tensor_factory (#7856) This should fix the problem where attempts to test bool are often wonky in OSS and fail UBSAN internally; it is undefined behavior to store a value other than 0 or 1 for type bool. * Support Half/BFloat16 in prod operator (#7857) Partial fix for #7748.
zonglinpeng
pushed a commit
to zonglinpeng/executorch
that referenced
this pull request
Jan 30, 2025
* Coerce to true_ctype in tensor_factory (pytorch#7856) This should fix the problem where attempts to test bool are often wonky in OSS and fail UBSAN internally; it is undefined behavior to store a value other than 0 or 1 for type bool. * Support Half/BFloat16 in prod operator (pytorch#7857) Partial fix for pytorch#7748.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partial fix for #7748.