Skip to content

Support Half/BFloat16 in select_scatter #7865

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 23, 2025
Merged

Support Half/BFloat16 in select_scatter #7865

merged 2 commits into from
Jan 23, 2025

Conversation

swolchok
Copy link
Contributor

Partial fix for #7748.

[ghstack-poisoned]
@swolchok
Copy link
Contributor Author

swolchok commented Jan 23, 2025

Stack from ghstack (oldest at bottom):

Copy link

pytorch-bot bot commented Jan 23, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7865

Note: Links to docs will display an error until the docs builds have been completed.

⏳ No Failures, 6 Pending

As of commit 631411d with merge base 03cba2c (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 23, 2025
swolchok added a commit that referenced this pull request Jan 23, 2025
Partial fix for #7748.

ghstack-source-id: a87a5af
ghstack-comment-id: 2608598121
Pull Request resolved: #7865
@swolchok swolchok requested a review from lucylq January 23, 2025 00:47
@swolchok swolchok added the release notes: ops & kernels Changes to the opset and any new / changed kernel implementations label Jan 23, 2025
@swolchok
Copy link
Contributor Author

everything is green except unittest jobs which appear to have fallen victim to an existing error on main. rebasing out of abundance of caution.

[ghstack-poisoned]
swolchok added a commit that referenced this pull request Jan 23, 2025
Partial fix for #7748.

ghstack-source-id: 4693e85
ghstack-comment-id: 2608598121
Pull Request resolved: #7865
@swolchok
Copy link
Contributor Author

macos unittest failure is a known problem that was on main, landing

@swolchok swolchok merged commit a469bf2 into main Jan 23, 2025
43 of 44 checks passed
@swolchok swolchok deleted the gh/swolchok/184/head branch January 23, 2025 18:14
YIWENX14 pushed a commit that referenced this pull request Jan 28, 2025
zonglinpeng pushed a commit to zonglinpeng/executorch that referenced this pull request Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. release notes: ops & kernels Changes to the opset and any new / changed kernel implementations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants