Skip to content

Support Half/BFloat16 in upsample_nearest2d #7911

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 28, 2025
Merged

Conversation

swolchok
Copy link
Contributor

Partial fix for #7748.

[ghstack-poisoned]
[ghstack-poisoned]
@swolchok
Copy link
Contributor Author

swolchok commented Jan 23, 2025

Stack from ghstack (oldest at bottom):

Copy link

pytorch-bot bot commented Jan 23, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7911

Note: Links to docs will display an error until the docs builds have been completed.

⏳ No Failures, 36 Pending

As of commit c737322 with merge base 58bda89 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 23, 2025
swolchok added a commit that referenced this pull request Jan 23, 2025
Partial fix for #7748.

ghstack-source-id: a3582c7
ghstack-comment-id: 2611102582
Pull Request resolved: #7911
@swolchok swolchok requested a review from GregoryComer January 23, 2025 21:59
@swolchok swolchok added the release notes: ops & kernels Changes to the opset and any new / changed kernel implementations label Jan 23, 2025
Base automatically changed from gh/swolchok/197/head to main January 28, 2025 16:30
[ghstack-poisoned]
swolchok added a commit that referenced this pull request Jan 28, 2025
Partial fix for #7748.

ghstack-source-id: 9f6f530
ghstack-comment-id: 2611102582
Pull Request resolved: #7911
@swolchok
Copy link
Contributor Author

cI was all green prior to rebase-for-land. did manual smoke test (local build & ctest) just to be safe, and landing without waiting for CI to run again.

@swolchok swolchok merged commit 34a1c14 into main Jan 28, 2025
41 checks passed
@swolchok swolchok deleted the gh/swolchok/198/head branch January 28, 2025 16:34
YIWENX14 pushed a commit that referenced this pull request Jan 28, 2025
zonglinpeng pushed a commit to zonglinpeng/executorch that referenced this pull request Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. release notes: ops & kernels Changes to the opset and any new / changed kernel implementations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants