Skip to content

Fix for ambiguous overload in kernels/portable/cpu/op_gelu.cpp #7937

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

zingo
Copy link
Collaborator

@zingo zingo commented Jan 24, 2025

This fix a error you get when using newer (more strict) compiler version

cc @digantdesai @freddan80 @per @oscarandersson8218

This fix a error you get when using newer (more strict) compiler version

Signed-off-by: Zingo Andersen <[email protected]>
Change-Id: I2f64949e35ecd2cb3604c1579ea38a5d9d972118
Copy link

pytorch-bot bot commented Jan 24, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7937

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 2 Cancelled Jobs

As of commit 2789336 with merge base b043e0d (image):

NEW FAILURE - The following job has failed:

CANCELLED JOBS - The following jobs were cancelled. Please retry:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 24, 2025
@zingo zingo added partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm ciflow/trunk labels Jan 24, 2025
@zingo zingo requested review from swolchok and digantdesai January 24, 2025 15:48
@swolchok swolchok added the release notes: ops & kernels Changes to the opset and any new / changed kernel implementations label Jan 24, 2025
@zingo zingo added topic: not user facing and removed release notes: ops & kernels Changes to the opset and any new / changed kernel implementations labels Jan 24, 2025
Copy link
Contributor

@swolchok swolchok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@zingo zingo marked this pull request as ready for review January 24, 2025 15:59
@zingo zingo added the release notes: ops & kernels Changes to the opset and any new / changed kernel implementations label Jan 24, 2025
@zingo
Copy link
Collaborator Author

zingo commented Jan 24, 2025

Sorry for removing the label, I think it's a WebGUI problem in github if labels are created in parallel while the "add label window" is open.
I have noticed this will CLA before, if you are fast and open the Label "cogwheel" before other labels are added by other people/bots they are not selected in your popup and get removed when you close it (e.g. when you adding yours).

@zingo
Copy link
Collaborator Author

zingo commented Jan 24, 2025

@digantdesai OK to merge? (Not in Arm folders so Ill ask for permission here :) )

@mergennachin mergennachin merged commit 1bf20e3 into pytorch:main Jan 24, 2025
107 of 114 checks passed
@mergennachin
Copy link
Contributor

Just merged, thanks

YIWENX14 pushed a commit that referenced this pull request Jan 28, 2025
This fix a error you get when using newer (more strict) compiler version


Change-Id: I2f64949e35ecd2cb3604c1579ea38a5d9d972118

Signed-off-by: Zingo Andersen <[email protected]>
zonglinpeng pushed a commit to zonglinpeng/executorch that referenced this pull request Jan 30, 2025
…ch#7937)

This fix a error you get when using newer (more strict) compiler version


Change-Id: I2f64949e35ecd2cb3604c1579ea38a5d9d972118

Signed-off-by: Zingo Andersen <[email protected]>
@zingo zingo deleted the Fix-for-ambiguous-overload-in-kernels/portable/cpu/op_gelu.cpp branch February 13, 2025 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm release notes: ops & kernels Changes to the opset and any new / changed kernel implementations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants