Skip to content

aten.leakyrelu.default in unary_ops #7975

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 28, 2025

Conversation

hossein1387
Copy link
Contributor

Differential Revision: D68688186

Copy link

pytorch-bot bot commented Jan 27, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7975

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure

As of commit ac77b1c with merge base 7bc06d1 (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 27, 2025
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D68688186

hossein1387 added a commit to hossein1387/executorch that referenced this pull request Jan 27, 2025
Summary: Pull Request resolved: pytorch#7975

Differential Revision: D68688186
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D68688186

@SS-JIA SS-JIA added the release notes: vulkan Changes to the Vulkan backend delegate label Jan 27, 2025
Differential Revision: D68688186
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D68688186

@@ -114,6 +114,17 @@ float get_val_or_inf(ComputeGraph& graph, const ValueRef& val, bool max) {
"hardshrink"); \
}

#define DEFINE_LEAKY_RELU_FN(op_name) \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do we need a macro that is only used once?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I couldn't use other macros (DEFINE_ACTIVATION_FN for instance) since the func signature is different. Also, I thought maybe other activations (like PReLU) could use the same macro in the future.

@facebook-github-bot
Copy link
Contributor

@hossein1387 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot facebook-github-bot merged commit de6f1a4 into pytorch:main Jan 28, 2025
45 of 47 checks passed
YIWENX14 pushed a commit that referenced this pull request Jan 28, 2025
Differential Revision: D68688186

Pull Request resolved: #7975
zonglinpeng pushed a commit to zonglinpeng/executorch that referenced this pull request Jan 30, 2025
Differential Revision: D68688186

Pull Request resolved: pytorch#7975
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported release notes: vulkan Changes to the Vulkan backend delegate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants