-
Notifications
You must be signed in to change notification settings - Fork 536
aten.leakyrelu.default in unary_ops #7975
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
aten.leakyrelu.default in unary_ops #7975
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7975
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New FailureAs of commit ac77b1c with merge base 7bc06d1 ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This pull request was exported from Phabricator. Differential Revision: D68688186 |
Summary: Pull Request resolved: pytorch#7975 Differential Revision: D68688186
d92f078
to
0c89c5f
Compare
This pull request was exported from Phabricator. Differential Revision: D68688186 |
Differential Revision: D68688186
0c89c5f
to
ac77b1c
Compare
This pull request was exported from Phabricator. Differential Revision: D68688186 |
@@ -114,6 +114,17 @@ float get_val_or_inf(ComputeGraph& graph, const ValueRef& val, bool max) { | |||
"hardshrink"); \ | |||
} | |||
|
|||
#define DEFINE_LEAKY_RELU_FN(op_name) \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why do we need a macro that is only used once?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I couldn't use other macros (DEFINE_ACTIVATION_FN for instance) since the func signature is different. Also, I thought maybe other activations (like PReLU) could use the same macro in the future.
@hossein1387 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Differential Revision: D68688186 Pull Request resolved: #7975
Differential Revision: D68688186 Pull Request resolved: pytorch#7975
Differential Revision: D68688186