Skip to content

support input_pos > 0 for prefill model #8127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

billmguo
Copy link
Contributor

@billmguo billmguo commented Feb 1, 2025

Summary: test input_pos>0 for prefill, not intention for landing but for sync with qc

Differential Revision: D68847677

Summary: test input_pos>0 for prefill, not intention for landing but for sync with qc

Differential Revision: D68847677
Copy link

pytorch-bot bot commented Feb 1, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/8127

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures, 2 Unrelated Failures

As of commit 38d22fb with merge base 92e7dbd (image):

NEW FAILURES - The following jobs have failed:

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 1, 2025
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D68847677

Copy link

github-actions bot commented Feb 1, 2025

This PR needs a release notes: label

If your changes are user facing and intended to be a part of release notes, please use a label starting with release notes:.

If not, please add the topic: not user facing label.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "topic: not user facing"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@billmguo
Copy link
Contributor Author

billmguo commented Feb 2, 2025

let me explain a little on this, Tokens, freq_cos, freq_sin, mask, k, v caches will be passed in both prefill and decode model
The freq_cos /freq_sin/mask . Here we remove input_pos since prefill model inference will be like AR-pre_fill_len model , the input_pos does not come into play, runtime can fill freq_cos/freq_sin/kv/mask information directly. let me know about your thoughts, in case you have better ideas to support multi-turn, that will be great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants