Skip to content

Prioritise FuseBatchnorm2D over DecomposeBatchNormPass #8140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 6, 2025

Conversation

tom-arm
Copy link
Collaborator

@tom-arm tom-arm commented Feb 3, 2025

  • As it is preferable to fuse batch_norm over decomposing it, prioritise this pass higher

Change-Id: I353d324ca31b85f1c62c866c93b49253ab7b4014

cc @digantdesai @freddan80 @per @zingo @oscarandersson8218

* As it is preferable to fuse batch_norm over decomposing it, prioritise this pass higher

Signed-off-by: Tom Allsop <[email protected]>
Change-Id: I353d324ca31b85f1c62c866c93b49253ab7b4014
Copy link

pytorch-bot bot commented Feb 3, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/8140

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

❌ 2 New Failures, 1 Cancelled Job, 2 Unrelated Failures

As of commit b8060ae with merge base 637cc32 (image):

NEW FAILURES - The following jobs have failed:

CANCELLED JOB - The following job was cancelled. Please retry:

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 3, 2025
@tom-arm tom-arm added partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm ciflow/trunk topic: not user facing labels Feb 3, 2025
@zingo
Copy link
Collaborator

zingo commented Feb 6, 2025

Failed tests are unrelated

@zingo zingo merged commit 883ff14 into pytorch:main Feb 6, 2025
103 of 111 checks passed
@tom-arm tom-arm deleted the reorder_batchnorm_passes branch February 6, 2025 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm topic: not user facing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants