-
Notifications
You must be signed in to change notification settings - Fork 536
don't double-install executorch for one-off linux pull-time jobs #8142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Stack from ghstack (oldest at bottom): |
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/8142
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (2 Unrelated Failures)As of commit 62f7f19 with merge base 637cc32 ( BROKEN TRUNK - The following jobs failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
I remember somebody mentioning they wanted install_executorch to be the one solution previously. CI is red for these jobs due to timeouts and we should not block a time improvement just because it is not the ideal long-term solution. ghstack-source-id: b256e67 ghstack-comment-id: 2631587314 Pull Request resolved: #8142
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was going off of old information, and was afraid that this change would remove all CI testing of install_executorch.sh.
In the past, the CI setup scripts did their own version of install_executorch, but now it calls down to the script:
executorch/.ci/scripts/utils.sh
Line 23 in 821a2fe
install_executorch() { |
So this looks good! Thanks for removing these.
I remember somebody mentioning they wanted install_executorch to be the one solution previously. CI is red for these jobs due to timeouts and we should not block a time improvement just because it is not the ideal long-term solution.