Skip to content

don't double-install executorch for one-off linux pull-time jobs #8142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 4, 2025

Conversation

swolchok
Copy link
Contributor

@swolchok swolchok commented Feb 3, 2025

I remember somebody mentioning they wanted install_executorch to be the one solution previously. CI is red for these jobs due to timeouts and we should not block a time improvement just because it is not the ideal long-term solution.

[ghstack-poisoned]
@swolchok
Copy link
Contributor Author

swolchok commented Feb 3, 2025

Copy link

pytorch-bot bot commented Feb 3, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/8142

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (2 Unrelated Failures)

As of commit 62f7f19 with merge base 637cc32 (image):

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

swolchok added a commit that referenced this pull request Feb 3, 2025
I remember somebody mentioning they wanted install_executorch to be the one solution previously. CI is red for these jobs due to timeouts and we should not block a time improvement just because it is not the ideal long-term solution.

ghstack-source-id: b256e67
ghstack-comment-id: 2631587314
Pull Request resolved: #8142
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 3, 2025
@swolchok swolchok added the release notes: build Changes related to build, including dependency upgrades, build flags, optimizations, etc. label Feb 3, 2025
@swolchok swolchok requested review from helunwencser, cccclai, mergennachin and dbort and removed request for helunwencser February 3, 2025 17:24
Copy link
Contributor

@dbort dbort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was going off of old information, and was afraid that this change would remove all CI testing of install_executorch.sh.

In the past, the CI setup scripts did their own version of install_executorch, but now it calls down to the script:

install_executorch() {

So this looks good! Thanks for removing these.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. release notes: build Changes related to build, including dependency upgrades, build flags, optimizations, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants