Skip to content

[cadence][hifi] update quantized_relu_per_tensor_out signature to match internal flow #8143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 5, 2025
Merged

[cadence][hifi] update quantized_relu_per_tensor_out signature to match internal flow #8143

merged 1 commit into from
Feb 5, 2025

Conversation

zonglinpeng
Copy link
Contributor

Differential Revision: D69015308

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Feb 3, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/8143

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

❌ 1 New Failure

As of commit ae50298 with merge base ee6f2d9 (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 3, 2025
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D69015308

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D69015308

@zonglinpeng zonglinpeng changed the title quantized_relu_per_tensor_out [cadence][hifi] update quantized_relu_per_tensor_out signature to match internal flow Feb 3, 2025
@zonglinpeng @facebook-github-bot
Fixed quantized_relu_per_tensor_out (pytorch#8143)
ae50298 
Summary:

fix quantized_relu_per_tensor

Differential Revision: D69015308
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D69015308

hsharma35
hsharma35 reviewed Feb 5, 2025
View reviewed changes
backends/cadence/hifi/operators/op_quantized_relu_out.cpp
@@ -48,24 +48,27 @@ void quantized_relu_(
void quantized_relu_per_tensor_out(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this not the operator called by ET? If so, please move this inside an anonymous namespace.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

realized most of hifi ops are not in anonymous namespace yet. Will do separately

@facebook-github-bot facebook-github-bot merged commit 56baff7 into pytorch:main Feb 5, 2025
45 of 47 checks passed
This was referenced Feb 11, 2025
Open
Open
This was referenced Feb 24, 2025
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hsharma35 hsharma35 hsharma35 approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported topic: not user facing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zonglinpeng @facebook-github-bot @hsharma35