[executorch] Create target for named_data_map #8147
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/8147
Note: Links to docs will display an error until the docs builds have been completed. This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
Pull Request resolved: #8110 named_data_map depends on tensor_layout, which depends on exec_lib. Move it out from core, as we have a circular dep when exec_lib is part of core. Also make TensorLayout::create return a const. ghstack-source-id: 264157518 Differential Revision: [D68972364](https://our.internmc.facebook.com/intern/diff/D68972364/)
kirklandsign
force-pushed
the
gh/lucylq/34/orig
branch
from
f0d55a9 to
d45ac4c
Compare
lucylq
approved these changes
Feb 3, 2025
This was referenced Feb 11, 2025
This was referenced Feb 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
named_data_map depends on tensor_layout, which depends on exec_lib.
Move it out from core, as we have a circular dep when exec_lib is part of core.
Also make TensorLayout::create return a const.