.gitignores for ios demo artifacts #8153
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/8153
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit b5a92cb with merge base 78752a0 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
@pytorchbot label "topic: not user facing" |
dustinfreeman
force-pushed
the
gitignore-ios
branch
from
be694d5 to
5a90013
Compare
|
Looks good to me. Can you rebase please? |
dustinfreeman
force-pushed
the
gitignore-ios
branch
2 times, most recently
from
98de889 to
519ac94
Compare
I'm having to manually rebase each time new commits come up on the main branch. You have my permission to rebase it yourself whenever you do the final review. |
shoumikhin
approved these changes
Feb 6, 2025
dustinfreeman
force-pushed
the
gitignore-ios
branch
from
519ac94 to
b5a92cb
Compare
This was referenced Feb 11, 2025
This was referenced Feb 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Following the iOS Demo app instructions generates files that are not tracked in version control. This updates the main
.gitignore, and adds a new.gitignorespecific to the generated iOS Xcode project.Test plan
This has been tested, in the sense that I have run through the instructions to the end of the iOS demo without issue, and only needed to make the
.gitignorechanges so I didn't have the build artifacts appear as untracked in version control.It is possible these changes may lead to undesired effects in esoteric unofficial workflows with this repo, but I can't know that unless someone speaks up about it. I couldn't find any prior discussion about this.