.gitignores for ios demo artifacts#8153
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/8153
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ✅ No FailuresAs of commit e4dd77a with merge base 9de4c16 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
@pytorchbot label "topic: not user facing" |
be694d5 to
5a90013
Compare
|
Looks good to me. Can you rebase please? |
98de889 to
519ac94
Compare
I'm having to manually rebase each time new commits come up on the main branch. You have my permission to rebase it yourself whenever you do the final review. |
519ac94 to
b5a92cb
Compare
|
Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as |
This PR needs a
|
|
This demo app now lives at https://github.com/meta-pytorch/executorch-examples/tree/main/mv3/apple/ExecuTorchDemo |
@shoumikhin confirming this PR can be closed now. |
|
Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as |
|
Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as |
|
Closing as I assume an internal dev has taken over this process. |
Summary
Following the iOS Demo app instructions generates files that are not tracked in version control. This updates the main
.gitignore, and adds a new.gitignorespecific to the generated iOS Xcode project.Test plan
This has been tested, in the sense that I have run through the instructions to the end of the iOS demo without issue, and only needed to make the
.gitignorechanges so I didn't have the build artifacts appear as untracked in version control.It is possible these changes may lead to undesired effects in esoteric unofficial workflows with this repo, but I can't know that unless someone speaks up about it. I couldn't find any prior discussion about this.