create MetaETDumpGen class to abstract copy_tensor_to_debug_buffer function #8157
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/8157
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New FailureAs of commit 8ec891c with merge base 883ff14 ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D69079952 |
|
@pytorchbot label "topic: not user facing" |
Gasoonjia
force-pushed
the
export-D69079952
branch
from
8e0b82b to
41319f9
Compare
Gasoonjia
added a commit
to Gasoonjia/executorch-1
that referenced
this pull request
Feb 3, 2025
…nction (pytorch#8157) Summary: This diff creates a new class called `MetaETDumpGen` to abstract the `copy_tensor_to_debug_buffer` function from the `ETDumpGen` class, while keep the `ETDumpGen` class as it is, which makes user able to implement their own way dumping data into buffer, while make the API back-compatible. Differential Revision: D69079952
|
This pull request was exported from Phabricator. Differential Revision: D69079952 |
Gasoonjia
added a commit
to Gasoonjia/executorch-1
that referenced
this pull request
Feb 3, 2025
…nction (pytorch#8157) Summary: This diff creates a new class called `MetaETDumpGen` to abstract the `copy_tensor_to_debug_buffer` function from the `ETDumpGen` class, while keep the `ETDumpGen` class as it is, which makes user able to implement their own way dumping data into buffer, while make the API back-compatible. Differential Revision: D69079952
Gasoonjia
force-pushed
the
export-D69079952
branch
from
41319f9 to
fac36ed
Compare
|
This pull request was exported from Phabricator. Differential Revision: D69079952 |
tarun292
approved these changes
Feb 4, 2025
…nction (pytorch#8157) Summary: This diff creates a new class called `MetaETDumpGen` to abstract the `copy_tensor_to_debug_buffer` function from the `ETDumpGen` class, while keep the `ETDumpGen` class as it is, which makes user able to implement their own way dumping data into buffer, while make the API back-compatible. Reviewed By: tarun292 Differential Revision: D69079952
Gasoonjia
force-pushed
the
export-D69079952
branch
from
fac36ed to
8ec891c
Compare
|
This pull request was exported from Phabricator. Differential Revision: D69079952 |
This was referenced Feb 11, 2025
This was referenced Feb 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: This diff creates a new class called
MetaETDumpGento abstract thecopy_tensor_to_debug_bufferfunction from theETDumpGenclass, while keep theETDumpGenclass as it is, which makes user able to implement their own way dumping data into buffer, while make the API back-compatible.Differential Revision: D69079952