open source quantized_fully_connected#8164
Merged
facebook-github-bot merged 1 commit intopytorch:mainfrom Feb 5, 2025
Merged
Conversation
Summary: titled TODO: add test for quantized_fully_connected by graphbuilder Differential Revision: D69085419
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/8164
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (2 Unrelated Failures)As of commit ed103a3 with merge base 9441003 ( BROKEN TRUNK - The following jobs failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D69085419 |
hsharma35
reviewed
Feb 5, 2025
| offset, | ||
| out); | ||
| } else { | ||
| ET_CHECK_MSG( |
Contributor
There was a problem hiding this comment.
Replace this with ET_KERNEL_CHECK please
hsharma35
approved these changes
Feb 5, 2025
| static_cast<int32_t>(out_multiplier), | ||
| static_cast<int32_t>(out_shift), | ||
| out_zero_point); | ||
| ET_DCHECK_MSG(ret == 0, "HiFi quantized::fully_connected failed"); |
| offset, | ||
| out); | ||
| } else { | ||
| ET_CHECK_MSG( |
Contributor
There was a problem hiding this comment.
Please use ET_KERNEL_CHECK instead
This was referenced Feb 11, 2025
This was referenced Feb 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
titled
TODO: add test for quantized_fully_connected by graphbuilder
Differential Revision: D69085419