Skip to content

Fix missing canonicalize_program in qnn #8188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 4, 2025
Merged

Fix missing canonicalize_program in qnn #8188

merged 2 commits into from
Feb 4, 2025

Conversation

metascroy
Copy link
Contributor

@metascroy metascroy commented Feb 4, 2025 •
edited by pytorch-bot bot
Loading

Addresses #6955

cc @cccclai

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 4, 2025
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Feb 4, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/8188

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@metascroy metascroy requested a review from cccclai February 4, 2025 19:16
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 4, 2025

This PR needs a release notes: label

If your changes are user facing and intended to be a part of release notes, please use a label starting with release notes:.

If not, please add the topic: not user facing label.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "topic: not user facing"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@metascroy metascroy mentioned this pull request Feb 4, 2025
Closed
@metascroy metascroy added the module: qnn Issues related to Qualcomm's QNN delegate and code under backends/qualcomm/ label Feb 4, 2025
cccclai
cccclai approved these changes Feb 4, 2025
View reviewed changes
Copy link
Contributor

@cccclai cccclai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@metascroy metascroy merged commit ee6f2d9 into pytorch:main Feb 4, 2025
39 of 41 checks passed
This was referenced Feb 11, 2025
Open
Open
This was referenced Feb 24, 2025
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cccclai cccclai cccclai approved these changes

@haowhsu-quic haowhsu-quic Awaiting requested review from haowhsu-quic

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. module: qnn Issues related to Qualcomm's QNN delegate and code under backends/qualcomm/
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@metascroy @cccclai @facebook-github-bot