-
Notifications
You must be signed in to change notification settings - Fork 537
Add strict=True
explicit flag to Executorch invocations to torch.export.export
#8190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/8190
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ⏳ No Failures, 11 PendingAs of commit a55b2e6 with merge base 3e64c4e ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This pull request was exported from Phabricator. Differential Revision: D69068797 |
@pytorchbot label "topic: not user facing" |
Summary: Pull Request resolved: pytorch#8190 Reviewed By: avikchaudhuri Differential Revision: D69068797
20e82e3
to
b57ae5b
Compare
This pull request was exported from Phabricator. Differential Revision: D69068797 |
strict=True
explicit flag to Executorch invocations to torch.export.export
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Would we moved to strict=False as suggested?
Summary: Pull Request resolved: pytorch#8190 Reviewed By: avikchaudhuri, iseeyuan Differential Revision: D69068797
b57ae5b
to
a55b2e6
Compare
This pull request was exported from Phabricator. Differential Revision: D69068797 |
Differential Revision: D69068797