Skip to content

Add strict=True explicit flag to Executorch invocations to torch.export.export #8190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 5, 2025

Conversation

gmagogsfm
Copy link
Contributor

Differential Revision: D69068797

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 4, 2025
Copy link

pytorch-bot bot commented Feb 4, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/8190

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

⏳ No Failures, 11 Pending

As of commit a55b2e6 with merge base 3e64c4e (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D69068797

@gmagogsfm
Copy link
Contributor Author

@pytorchbot label "topic: not user facing"

gmagogsfm added a commit to gmagogsfm/executorch-1 that referenced this pull request Feb 5, 2025
Summary: Pull Request resolved: pytorch#8190

Reviewed By: avikchaudhuri

Differential Revision: D69068797
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D69068797

@gmagogsfm gmagogsfm changed the title executorch Add strict=True explicit flag to Executorch invocations to torch.export.export Feb 5, 2025
Copy link
Contributor

@iseeyuan iseeyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Would we moved to strict=False as suggested?

Summary: Pull Request resolved: pytorch#8190

Reviewed By: avikchaudhuri, iseeyuan

Differential Revision: D69068797
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D69068797

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported topic: not user facing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants