Skip to content

Trial revert of --use-pt-pinned-commit for llava #8193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

swolchok
Copy link
Contributor

@swolchok swolchok commented Feb 4, 2025

Now that we've bumped the nightly version, let's make sure that --use-pt-pinned-commit is definitely causing the long running times here (#8180).

[ghstack-poisoned]
@swolchok
Copy link
Contributor Author

swolchok commented Feb 4, 2025

Stack from ghstack (oldest at bottom):

Copy link

pytorch-bot bot commented Feb 4, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/8193

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

❌ 2 New Failures

As of commit caec336 with merge base a3455d9 (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 4, 2025
swolchok added a commit that referenced this pull request Feb 4, 2025
Now that we've bumped the nightly version, let's make sure that --use-pt-pinned-commit is definitely causing the long running times here.

ghstack-source-id: 252f25c7b079a3db0b8129602d40d8bcc818e67f
ghstack-comment-id: 2634989174
Pull Request resolved: #8193
@swolchok swolchok marked this pull request as draft February 4, 2025 20:27
Copy link

github-actions bot commented Feb 4, 2025

This PR needs a release notes: label

If your changes are user facing and intended to be a part of release notes, please use a label starting with release notes:.

If not, please add the topic: not user facing label.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "topic: not user facing"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants