method_meta add uses_backend function #8198

cmt0 · 2025-02-04T22:49:58Z

Summary: For a runtime that supports models of a couple different types it helps to be able to check ahead of time whether certain backend types are present. In our case, there are processors that can use this information to make scheduling decisions without having the actual required backend implementations present.

Differential Revision: D69143825

pytorch-bot · 2025-02-04T22:50:01Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/8198

📄 Preview Python docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

ROCM Infra failures during checkout of PyTorch

✅ No Failures

As of commit d18c44a with merge base 3e64c4e ():
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

facebook-github-bot · 2025-02-04T22:50:07Z

This pull request was exported from Phabricator. Differential Revision: D69143825

dbort

Thanks for adding this! It's a reasonable feature.

runtime/executor/method_meta.h

dbort · 2025-02-04T23:04:13Z

runtime/executor/method_meta.h

+  /**
+   * Check to see if a backend is used in this method.
+   *
+   * @returns Whether a backend is used in this method.
+   */


Please add a @param, and clarify true-vs-false rather than "whether".

Suggested change

/**

* Check to see if a backend is used in this method.

*

* @returns Whether a backend is used in this method.

*/

/**

* Check to see if a backend is used by this method.

*

* @param backend_name The name of the backend to search for.

* @returns true if this method uses this backend; false otherwise.

*/

Added clarification

Please add the @param line too

runtime/executor/method_meta.cpp

Summary: For a runtime that supports models of a couple different types it helps to be able to check ahead of time whether certain backend types are present. In our case, there are processors that can use this information to make scheduling decisions without having the actual required backend implementations present. Differential Revision: D69143825

facebook-github-bot · 2025-02-05T19:09:47Z

This pull request was exported from Phabricator. Differential Revision: D69143825

cmt0 · 2025-02-05T19:15:34Z

@pytorchbot label "release notes: Adds method meta function which checks whether a backend is used by a program"

pytorch-bot · 2025-02-05T19:15:37Z

Didn't find following labels among repository labels: release notes: Adds method meta function which checks whether a backend is used by a program

Summary: For a runtime that supports models of a couple different types it helps to be able to check ahead of time whether certain backend types are present. In our case, there are processors that can use this information to make scheduling decisions without having the actual required backend implementations present. Differential Revision: D69143825

facebook-github-bot · 2025-02-05T19:16:54Z

This pull request was exported from Phabricator. Differential Revision: D69143825

Summary: For a runtime that supports models of a couple different types it helps to be able to check ahead of time whether certain backend types are present. In our case, there are processors that can use this information to make scheduling decisions without having the actual required backend implementations present. Differential Revision: D69143825

facebook-github-bot · 2025-02-05T19:17:24Z

This pull request was exported from Phabricator. Differential Revision: D69143825

Summary: For a runtime that supports models of a couple different types it helps to be able to check ahead of time whether certain backend types are present. In our case, there are processors that can use this information to make scheduling decisions without having the actual required backend implementations present. Differential Revision: D69143825

facebook-github-bot · 2025-02-05T19:17:39Z

This pull request was exported from Phabricator. Differential Revision: D69143825

cmt0 · 2025-02-05T19:23:01Z

@pytorchbot label "release notes: misc"

Summary: For a runtime that supports models of a couple different types it helps to be able to check ahead of time whether certain backend types are present. In our case, there are processors that can use this information to make scheduling decisions without having the actual required backend implementations present. Differential Revision: D69143825

facebook-github-bot · 2025-02-05T19:24:04Z

This pull request was exported from Phabricator. Differential Revision: D69143825

cmt0 · 2025-02-05T19:27:05Z

@dbort Does it need an ET_EXPERIMENTAL tag, or can I define it normally to avoid deprecated declarations warning?

dbort · 2025-02-05T19:38:38Z

@dbort Does it need an ET_EXPERIMENTAL tag, or can I define it normall to avoid deprecated declarations warning?

I think the new method is general enough to remove the ET_EXPERIMENTAL annotation. The behavior is well-defined compared to e.g. the instruction count.

Summary: For a runtime that supports models of a couple different types it helps to be able to check ahead of time whether certain backend types are present. In our case, there are processors that can use this information to make scheduling decisions without having the actual required backend implementations present. Reviewed By: dbort Differential Revision: D69143825

facebook-github-bot · 2025-02-05T19:50:29Z

This pull request was exported from Phabricator. Differential Revision: D69143825

Summary: For a runtime that supports models of a couple different types it helps to be able to check ahead of time whether certain backend types are present. In our case, there are processors that can use this information to make scheduling decisions without having the actual required backend implementations present. Reviewed By: dbort Differential Revision: D69143825

facebook-github-bot · 2025-02-05T20:03:00Z

This pull request was exported from Phabricator. Differential Revision: D69143825

facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 4, 2025

facebook-github-bot added the fb-exported label Feb 4, 2025

swolchok requested a review from dbort February 4, 2025 22:57

dbort requested changes Feb 4, 2025

View reviewed changes

cmt0 force-pushed the export-D69143825 branch from 0993897 to 1ff1b1f Compare February 5, 2025 19:09

cmt0 force-pushed the export-D69143825 branch from 1ff1b1f to 9d7ed81 Compare February 5, 2025 19:16

cmt0 force-pushed the export-D69143825 branch from 9d7ed81 to 86b15c1 Compare February 5, 2025 19:17

cmt0 force-pushed the export-D69143825 branch from 86b15c1 to 54b7d77 Compare February 5, 2025 19:17

pytorch-bot bot added the release notes: misc Miscellaneous label Feb 5, 2025

cmt0 force-pushed the export-D69143825 branch from 54b7d77 to d5f51f6 Compare February 5, 2025 19:23

cmt0 changed the title ~~Method_Meta contains_backend check~~ method_meta add uses_backend function Feb 5, 2025

dbort added release notes: runtime Changes related to the core runtime which loads the program methods, initializes delegates, and runs and removed release notes: misc Miscellaneous labels Feb 5, 2025

dbort approved these changes Feb 5, 2025

View reviewed changes

cmt0 force-pushed the export-D69143825 branch from d5f51f6 to e4720f2 Compare February 5, 2025 19:50

cmt0 force-pushed the export-D69143825 branch from e4720f2 to d18c44a Compare February 5, 2025 20:02

facebook-github-bot merged commit edf3952 into pytorch:main Feb 6, 2025
47 checks passed

mergennachin mentioned this pull request Feb 6, 2025

Provide API to query backend availability at runtime #8267

Closed

This was referenced Feb 11, 2025

Weekly pr metrics report - 2025-02-01..2025-02-07 wdvr/pytorch#6

Open

Weekly pr metrics report - 2025-02-01..2025-02-07 wdvr/pytorch#8

Open

This was referenced Feb 24, 2025

Weekly pr metrics report - 2025-02-01..2025-02-07 wdvr/pytorch#10

Open

Weekly pr metrics report - 2025-02-01..2025-02-07 wdvr/pytorch#14

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

method_meta add uses_backend function #8198

method_meta add uses_backend function #8198

cmt0 commented Feb 4, 2025

pytorch-bot bot commented Feb 4, 2025 •

edited

Loading

facebook-github-bot commented Feb 4, 2025

dbort left a comment

dbort Feb 4, 2025

cmt0 Feb 5, 2025

dbort Feb 5, 2025 •

edited

Loading

facebook-github-bot commented Feb 5, 2025

cmt0 commented Feb 5, 2025

pytorch-bot bot commented Feb 5, 2025

facebook-github-bot commented Feb 5, 2025

facebook-github-bot commented Feb 5, 2025

facebook-github-bot commented Feb 5, 2025

cmt0 commented Feb 5, 2025

facebook-github-bot commented Feb 5, 2025

cmt0 commented Feb 5, 2025 •

edited

Loading

dbort commented Feb 5, 2025

facebook-github-bot commented Feb 5, 2025

facebook-github-bot commented Feb 5, 2025

-  /**
-   * Check to see if a backend is used in this method.
-   *
-   * @returns Whether a backend is used in this method.
-   */
+  /**
+   * Check to see if a backend is used by this method.
+   *
+   * @param backend_name The name of the backend to search for.
+   * @returns true if this method uses this backend; false otherwise.
+   */

method_meta add uses_backend function #8198

method_meta add uses_backend function #8198

Conversation

cmt0 commented Feb 4, 2025

pytorch-bot bot commented Feb 4, 2025 • edited Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/8198

❗ 1 Active SEVs

✅ No Failures

facebook-github-bot commented Feb 4, 2025

dbort left a comment

Choose a reason for hiding this comment

dbort Feb 4, 2025

Choose a reason for hiding this comment

cmt0 Feb 5, 2025

Choose a reason for hiding this comment

dbort Feb 5, 2025 • edited Loading

Choose a reason for hiding this comment

facebook-github-bot commented Feb 5, 2025

cmt0 commented Feb 5, 2025

pytorch-bot bot commented Feb 5, 2025

facebook-github-bot commented Feb 5, 2025

facebook-github-bot commented Feb 5, 2025

facebook-github-bot commented Feb 5, 2025

cmt0 commented Feb 5, 2025

facebook-github-bot commented Feb 5, 2025

cmt0 commented Feb 5, 2025 • edited Loading

dbort commented Feb 5, 2025

facebook-github-bot commented Feb 5, 2025

facebook-github-bot commented Feb 5, 2025

pytorch-bot bot commented Feb 4, 2025 •

edited

Loading

dbort Feb 5, 2025 •

edited

Loading

cmt0 commented Feb 5, 2025 •

edited

Loading