Skip to content

Arm backend: Add is_node_supported checks for 4 ops #8209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 6, 2025

Conversation

Erik-Lundell
Copy link
Collaborator

@Erik-Lundell Erik-Lundell commented Feb 5, 2025

For convolution, maxpool2d, avgpool2d, and sum.
The checks mostly target hardware constraints on
Ethos-U55, though convolution also checks for some
unsupported behavior.

cc @digantdesai @freddan80 @per @zingo @oscarandersson8218

@Erik-Lundell Erik-Lundell added partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm ciflow/trunk topic: not user facing labels Feb 5, 2025
Copy link

pytorch-bot bot commented Feb 5, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/8209

Note: Links to docs will display an error until the docs builds have been completed.

❌ 3 Cancelled Jobs

As of commit e0a9be4 with merge base 883ff14 (image):

CANCELLED JOBS - The following jobs were cancelled. Please retry:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 5, 2025
@Erik-Lundell
Copy link
Collaborator Author

Erik-Lundell commented Feb 5, 2025

CI failure is unrelated, the PR only limits what ops we partition and should not affect accuracy
Edit: as per Zingo's comment, CI failure is indeed related.

Signed-off-by: Erik Lundell <[email protected]>
Change-Id: I35e1de914f650f4e005e81f584033385179906a2
For convolution, maxpool2d, avgpool2d, and sum.
The checks mostly target hardware constraints on
Ethos-U55, though convolution also checks for some
unsupported behavior.

Signed-off-by: Erik Lundell <[email protected]>
Change-Id: Ic56119e438a476584c4c4b6007a81781907cc96c
@zingo
Copy link
Collaborator

zingo commented Feb 6, 2025

macos fails unrealted

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm topic: not user facing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants