Skip to content

[ET-VK][int4] patch 4-bit source transformation quantizer to support linear modules with biases #8224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 6, 2025

Conversation

nathanaelsee
Copy link
Contributor

@nathanaelsee nathanaelsee commented Feb 5, 2025

Stack from ghstack (oldest at bottom):

While LLaMa does not have biases, there are some models which will have biases in their linear modules.

Add support in the source transform quantizer for biases.

Differential Revision: D69072087

…linear modules with biases

While LLaMa does not have biases, there are some models which will have biases in their linear modules.

Add support in the source transform quantizer for biases.

Differential Revision: [D69072087](https://our.internmc.facebook.com/intern/diff/D69072087/)

[ghstack-poisoned]
Copy link

pytorch-bot bot commented Feb 5, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/8224

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

❌ 1 New Failure

As of commit fde8c70 with merge base 7805229 (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 5, 2025
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D69072087

…to support linear modules with biases"

While LLaMa does not have biases, there are some models which will have biases in their linear modules.

Add support in the source transform quantizer for biases.

Differential Revision: [D69072087](https://our.internmc.facebook.com/intern/diff/D69072087/)

[ghstack-poisoned]
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D69072087

…to support linear modules with biases"

While LLaMa does not have biases, there are some models which will have biases in their linear modules.

Add support in the source transform quantizer for biases.

Differential Revision: [D69072087](https://our.internmc.facebook.com/intern/diff/D69072087/)

[ghstack-poisoned]
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D69072087

…to support linear modules with biases"

While LLaMa does not have biases, there are some models which will have biases in their linear modules.

Add support in the source transform quantizer for biases.

Differential Revision: [D69072087](https://our.internmc.facebook.com/intern/diff/D69072087/)

[ghstack-poisoned]
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D69072087

@facebook-github-bot facebook-github-bot merged commit ab10ab3 into gh/nathanaelsee/1/base Feb 6, 2025
45 of 47 checks passed
@facebook-github-bot facebook-github-bot deleted the gh/nathanaelsee/1/head branch February 6, 2025 03:41
kirklandsign pushed a commit that referenced this pull request Feb 6, 2025
…linear modules with biases

Pull Request resolved: #8224

While LLaMa does not have biases, there are some models which will have biases in their linear modules.

Add support in the source transform quantizer for biases.
ghstack-source-id: 264952608
@exported-using-ghexport

Differential Revision: [D69072087](https://our.internmc.facebook.com/intern/diff/D69072087/)

Co-authored-by: Nathanael See <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported release notes: vulkan Changes to the Vulkan backend delegate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants