Skip to content

Fix unittests failures introduced from D69212362 #8278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 6, 2025
Merged

Fix unittests failures introduced from D69212362 #8278

merged 1 commit into from
Feb 6, 2025

Conversation

zhxchen17
Copy link
Contributor

Summary: There'll be some minor test failures caused by D69212362, fixing these before the source diff get landed.

Differential Revision: D69251115

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Feb 6, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/8278

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures, 2 Pending

As of commit 2681b06 with merge base 8ec08f9 (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 6, 2025
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D69251115

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 6, 2025

This PR needs a release notes: label

If your changes are user facing and intended to be a part of release notes, please use a label starting with release notes:.

If not, please add the topic: not user facing label.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "topic: not user facing"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

larryliu0820
larryliu0820 approved these changes Feb 6, 2025
View reviewed changes
Copy link
Contributor

@larryliu0820 larryliu0820 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the pre-emptive fix

@zhxchen17 @facebook-github-bot
Fix unittests failures introduced from D69212362 (pytorch#8278)
2681b06 
Summary:

There'll be some minor test failures caused by D69212362, fixing these before the source diff get landed.

Reviewed By: larryliu0820

Differential Revision: D69251115
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D69251115

@facebook-github-bot facebook-github-bot merged commit 41e7ffa into pytorch:main Feb 6, 2025
44 of 47 checks passed
This was referenced Feb 11, 2025
Open
Open
This was referenced Feb 24, 2025
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@larryliu0820 larryliu0820 larryliu0820 approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zhxchen17 @facebook-github-bot @larryliu0820