Skip to content

Convolution 1D optimized axis map #8312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

Abhi-hpp
Copy link
Contributor

@Abhi-hpp Abhi-hpp commented Feb 7, 2025

Summary: Add the kOptimizedAxisMap flag for conv1D.

Reviewed By: SS-JIA

Differential Revision: D67692963

Copy link

pytorch-bot bot commented Feb 7, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/8312

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 3ed106d with merge base 16281ce (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 7, 2025
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D67692963

Summary:

Add the kOptimizedAxisMap flag for conv1D.

Reviewed By: nathanaelsee, SS-JIA

Differential Revision: D67692963
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D67692963

@facebook-github-bot
Copy link
Contributor

Hi @Abhi-hpp!

Thank you for your pull request.

We require contributors to sign our Contributor License Agreement, and yours needs attention.

You currently have a record in our system, but the CLA is no longer valid, and will need to be resubmitted.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

nathanaelsee added a commit to nathanaelsee/executorch that referenced this pull request Feb 21, 2025
Summary:
Resubmit D67692963 (pytorch#8312)
Add the kOptimizedAxisMap flag for conv1D.

Differential Revision: D70009298
nathanaelsee added a commit to nathanaelsee/executorch that referenced this pull request Feb 21, 2025
Summary:

Resubmit D67692963 (pytorch#8312)
Add the kOptimizedAxisMap flag for conv1D.

Reviewed By: jorgep31415

Differential Revision: D70009298
@shoumikhin
Copy link
Contributor

@Abhi-hpp, @SS-JIA is this something we still need?

@SS-JIA SS-JIA closed this Mar 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported topic: not user facing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants