Expand dict API to allow dtype strings #8323
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/8323
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 27d0259 with merge base 513e92d ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D69335674 |
lucylq
added a commit
to lucylq/executorch-1
that referenced
this pull request
Feb 8, 2025
Summary: Allow users to specify dtypes using strings, instead of kernel keys. Note: this generates a 'fake' kernel key with no dim order data. I think this is OK, as I don't think ExecuTorch uses the kernel key for anything besides dtype. https://www.internalfb.com/code/fbsource/[c02ea3c66de17a60b2f0e65462a03ccf5cba9804]/fbcode/caffe2/torchgen/selective_build/selector.py?lines=49-52 Differential Revision: D69335674
lucylq
force-pushed
the
export-D69335674
branch
from
1ff7333 to
93eac94
Compare
|
This pull request was exported from Phabricator. Differential Revision: D69335674 |
larryliu0820
approved these changes
Feb 8, 2025
Summary: Allow users to specify dtypes using strings, instead of kernel keys. Note: this generates a 'fake' kernel key with no dim order data. I think this is OK, as I don't think ExecuTorch uses the kernel key for anything besides dtype. https://www.internalfb.com/code/fbsource/[c02ea3c66de17a60b2f0e65462a03ccf5cba9804]/fbcode/caffe2/torchgen/selective_build/selector.py?lines=49-52 Reviewed By: larryliu0820 Differential Revision: D69335674
lucylq
force-pushed
the
export-D69335674
branch
from
93eac94 to
27d0259
Compare
|
This pull request was exported from Phabricator. Differential Revision: D69335674 |
This was referenced Feb 11, 2025
This was referenced Feb 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Allow users to specify dtypes using strings, instead of kernel keys.
Note: this generates a 'fake' kernel key with no dim order data. I think this is OK, as I don't think ExecuTorch uses the kernel key for anything besides dtype.
https://www.internalfb.com/code/fbsource/[c02ea3c66de17a60b2f0e65462a03ccf5cba9804]/fbcode/caffe2/torchgen/selective_build/selector.py?lines=49-52
Differential Revision: D69335674