Skip to content

Add extension/llm/custom_ops/spinquant/test to CMake #8345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 20 commits into from
Feb 26, 2025

Conversation

swolchok
Copy link
Contributor

@swolchok swolchok commented Feb 10, 2025

Need to run it to make sure build changes in this directory aren't breaking things.

Test Plan: added EXPECT_TRUE(false) to fast_hadamard_transform_test.cpp, saw failure in test/run_oss_cpp_tests.sh

Copy link

pytorch-bot bot commented Feb 10, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/8345

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (1 Unrelated Failure)

As of commit b52f223 with merge base f3fc096 (image):

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

[ghstack-poisoned]
@swolchok swolchok force-pushed the gh/swolchok/242/head branch from 773ff37 to d4aaa36 Compare February 12, 2025 21:41
@swolchok
Copy link
Contributor Author

this isn't correct yet; test doesn't run when I run test/run_oss_cpp_tests.sh and I'm not sure why yet.

[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
@swolchok
Copy link
Contributor Author

temporarily adding --trace to the problem cmake command in build-llm-demo since I can't repro locally

@swolchok swolchok requested a review from dbort as a code owner February 24, 2025 17:39
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
swolchok added a commit that referenced this pull request Feb 25, 2025
Need to run it to make sure build changes in this directory aren't breaking things

ghstack-source-id: 765a3dc
ghstack-comment-id: 2648964965
Pull Request resolved: #8345
@swolchok
Copy link
Contributor Author

temporarily adding --trace to the problem cmake command in build-llm-demo since I can't repro locally

the correct cmake command was in extension/android_test/setup.sh, but I still can't figure out what's going on so now i'm just tracing all 4 cmake invocations

[ghstack-poisoned]
[ghstack-poisoned]
swolchok added a commit that referenced this pull request Feb 25, 2025
Need to run it to make sure build changes in this directory aren't breaking things

ghstack-source-id: 331d7ab
ghstack-comment-id: 2648964965
Pull Request resolved: #8345
@swolchok
Copy link
Contributor Author

the inexplicable build of tests seems to be because including abseil-cpp's CMakeLists.txt sets BUILD_TESTING to ON by default because it does include(CTest). trying out find_package(GTest) in et_cxx_test to see if it fixes the issue

[ghstack-poisoned]
@swolchok
Copy link
Contributor Author

this looks good, please review

[ghstack-poisoned]
[ghstack-poisoned]
@swolchok
Copy link
Contributor Author

Base automatically changed from gh/swolchok/280/head to main February 26, 2025 20:11
@swolchok swolchok merged commit 6410d47 into main Feb 26, 2025
49 of 85 checks passed
@swolchok swolchok deleted the gh/swolchok/242/head branch February 26, 2025 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. topic: not user facing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants