-
Notifications
You must be signed in to change notification settings - Fork 538
Add extension/llm/custom_ops/spinquant/test to CMake #8345
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/8345
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (1 Unrelated Failure)As of commit b52f223 with merge base f3fc096 ( BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
773ff37
to
d4aaa36
Compare
this isn't correct yet; test doesn't run when I run test/run_oss_cpp_tests.sh and I'm not sure why yet. |
temporarily adding |
the correct cmake command was in extension/android_test/setup.sh, but I still can't figure out what's going on so now i'm just tracing all 4 cmake invocations |
the inexplicable build of tests seems to be because including abseil-cpp's CMakeLists.txt sets BUILD_TESTING to ON by default because it does |
this looks good, please review |
ping reviewers @kirklandsign @kimishpatel @larryliu0820 @jackzhxng @iseeyuan @GregoryComer @dbort |
Need to run it to make sure build changes in this directory aren't breaking things.
Test Plan: added EXPECT_TRUE(false) to fast_hadamard_transform_test.cpp, saw failure in test/run_oss_cpp_tests.sh