Add cmake support for flat tensor #8349
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/8349
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit dba39e0 with merge base 71b8b75 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
lucylq
force-pushed
the
lfq.flat-tensor-cmake
branch
from
4d3aad8 to
1021cba
Compare
JacobSzwejbka
approved these changes
Feb 10, 2025
lucylq
force-pushed
the
lfq.flat-tensor-cmake
branch
from
1021cba to
dba39e0
Compare
lucylq
added a commit
that referenced
this pull request
Feb 11, 2025
Pull Request resolved: #8200 Add NamedDataMap as an arg to: - Method - load_method - parseTensor Use NamedDataMap to resolve external tensors in parseTensor. Test that the PTE + PTD file run well inside method_test. TODO: additional test cases. also, tests for mutable case with load_data_into when that is landed, see D69148652. Land after: #8349, which adds CMake support for FlatTensor. Note: dependency on D66580784, which fixes some failing RL tests exposed by this diff from inclusion of portable and aten headers. https://www.internalfb.com/code/fbsource/[2b74908ed03c34fbfd53fb57575eba0964fe0136][history]/arvr/projects/depthsensing/products/depthmanager/depth/stereo/MlStereoDisparityModelExecutorchBackend.h?lines=13-15 ghstack-source-id: 265828564 @exported-using-ghexport Differential Revision: [D67127327](https://our.internmc.facebook.com/intern/diff/D67127327/)
lucylq
added a commit
that referenced
this pull request
Feb 12, 2025
Pull Request resolved: #8200 Add NamedDataMap as an arg to: - Method - load_method - parseTensor Use NamedDataMap to resolve external tensors in parseTensor. Test that the PTE + PTD file run well inside method_test. TODO: additional test cases. also, tests for mutable case with load_data_into when that is landed, see D69148652. Land after: #8349, which adds CMake support for FlatTensor. Note: dependency on D66580784, which fixes some failing RL tests exposed by this diff from inclusion of portable and aten headers. https://www.internalfb.com/code/fbsource/[2b74908ed03c34fbfd53fb57575eba0964fe0136][history]/arvr/projects/depthsensing/products/depthmanager/depth/stereo/MlStereoDisparityModelExecutorchBackend.h?lines=13-15 ghstack-source-id: 265828564 @exported-using-ghexport Differential Revision: [D67127327](https://our.internmc.facebook.com/intern/diff/D67127327/) Co-authored-by: lucylq <[email protected]>
swolchok
reviewed
Feb 13, 2025
| "${CMAKE_CURRENT_BINARY_DIR}/_default_external_constant.ptd" | ||
| ) | ||
|
|
||
| set(test_env_ |
There was a problem hiding this comment.
stuff in this file seems to get clobbered if I rerun python test/utils/generate_gtest_cmakelists.py
There was a problem hiding this comment.
Oh I guess she manually wrote it instead of having it generated @lucylq can you take a look, or if its faster we can just black list this dir in the script
There was a problem hiding this comment.
shouldn't need to be blocklisted, just drop it from the config
There was a problem hiding this comment.
Ah, I generated it and then edited it to create the example pte files. I'll remove it from OSSTestConfig.json.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add cmake support for flat tensor
Test plan