Skip to content

Add CoreML support for to_edge_transform_and_lower #8505

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 17, 2025

Conversation

metascroy
Copy link
Contributor

@metascroy metascroy commented Feb 14, 2025

CoreML supports many ATen ops that decomposed during to_edge (e.g., SDPA, pixel_unshuffle, etc.)

To prevent that users can instead use to_edge_transform_and_lower, but CoreML partitioner did not support that flow. This PR adds support.

Test plan:
New coreml partitioner test.

Copy link

pytorch-bot bot commented Feb 14, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/8505

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (1 Unrelated Failure)

As of commit 12b1330 with merge base 740135f (image):

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 14, 2025
@metascroy metascroy force-pushed the coreml-partitioner-update branch from b39d406 to 12b1330 Compare February 14, 2025 22:45
@metascroy metascroy added the release notes: apple Changes to the Apple backend delegate label Feb 14, 2025
Copy link
Contributor

@cccclai cccclai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome, thank you! cc: @YifanShenSZ

@cccclai cccclai requested a review from YifanShenSZ February 14, 2025 23:28
@metascroy metascroy merged commit 159b932 into main Feb 17, 2025
52 of 54 checks passed
@metascroy metascroy deleted the coreml-partitioner-update branch February 17, 2025 01:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. release notes: apple Changes to the Apple backend delegate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants