Move shim/xplat to shim_et/xplat #8583
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Stack from ghstack (oldest at bottom): |
facebook-github-bot
added
the
CLA Signed
swolchok
added a commit
that referenced
this pull request
Feb 19, 2025
In preparation for replacing the checked-in files in shim/ with https://github.com/facebook/buck2-shims-meta as a submodule. The portions of this diff that are not a pure move are: - creation of shim_et/BUCK - movement of Android toolchains from shim/BUCK to shim_et/BUCK because they are not present in buck2-shims-meta - edits to .buckconfig - edit to Utils.cmake to point at shim_et// instead of shim// ghstack-source-id: c99b5d0 ghstack-comment-id: 2669799227 Pull Request resolved: #8583
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/8583
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New Failure, 1 Unrelated FailureAs of commit 8574dc7 with merge base b6ffe1a ( NEW FAILURE - The following job has failed:
BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This PR needs a
|
swolchok
added a commit
that referenced
this pull request
Feb 19, 2025
In preparation for replacing the checked-in files in shim/ with https://github.com/facebook/buck2-shims-meta as a submodule. The portions of this diff that are not a pure move are: - creation of shim_et/BUCK - movement of Android toolchains from shim/BUCK to shim_et/BUCK because they are not present in buck2-shims-meta - edits to .buckconfig - edit to Utils.cmake to point at shim_et// instead of shim// ghstack-source-id: 6747d6c ghstack-comment-id: 2669799227 Pull Request resolved: #8583
swolchok
added a commit
that referenced
this pull request
Feb 19, 2025
In preparation for replacing the checked-in files in shim/ with https://github.com/facebook/buck2-shims-meta as a submodule. The portions of this diff that are not a pure move are: - creation of shim_et/BUCK - movement of Android toolchains from shim/BUCK to shim_et/BUCK because they are not present in buck2-shims-meta - edits to .buckconfig - edit to Utils.cmake to point at shim_et// instead of shim// ghstack-source-id: af3cc9d ghstack-comment-id: 2669799227 Pull Request resolved: #8583
swolchok
added a commit
that referenced
this pull request
Feb 19, 2025
In preparation for replacing the checked-in files in shim/ with https://github.com/facebook/buck2-shims-meta as a submodule. The portions of this diff that are not a pure move are: - creation of shim_et/BUCK - movement of Android toolchains from shim/BUCK to shim_et/BUCK because they are not present in buck2-shims-meta - edits to .buckconfig - edit to Utils.cmake to point at shim_et// instead of shim// ghstack-source-id: f5fa84b ghstack-comment-id: 2669799227 Pull Request resolved: #8583
|
@swolchok has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
will replace with a PR initiated from internal repo |
swolchok
pushed a commit
that referenced
this pull request
Feb 21, 2025
Looks like in order to get this right, we're going to have to update some internal configuration and originate this PR from internal repo. Supersedes #8583 / D69882927. Differential Revision: [D69955361](https://our.internmc.facebook.com/intern/diff/D69955361/) [ghstack-poisoned]
swolchok
pushed a commit
that referenced
this pull request
Feb 21, 2025
Looks like in order to get this right, we're going to have to update some internal configuration and originate this PR from internal repo. Supersedes #8583 / D69882927. Differential Revision: [D69955361](https://our.internmc.facebook.com/intern/diff/D69955361/) ghstack-source-id: 267533770 Pull Request resolved: #8607
swolchok
added a commit
that referenced
this pull request
Feb 24, 2025
Looks like in order to get this right, we're going to have to update some internal configuration and originate this PR from internal repo. Supersedes #8583 / D69882927. Differential Revision: [D69955361](https://our.internmc.facebook.com/intern/diff/D69955361/) [ghstack-poisoned]
swolchok
added a commit
that referenced
this pull request
Feb 24, 2025
Pull Request resolved: #8607 Looks like in order to get this right, we're going to have to update some internal configuration and originate this PR from internal repo. Supersedes #8583 / D69882927. Differential Revision: [D69955361](https://our.internmc.facebook.com/intern/diff/D69955361/) ghstack-source-id: 268021896
swolchok
added a commit
that referenced
this pull request
Feb 24, 2025
Looks like in order to get this right, we're going to have to update some internal configuration and originate this PR from internal repo. Supersedes #8583 / D69882927. Differential Revision: [D69955361](https://our.internmc.facebook.com/intern/diff/D69955361/) [ghstack-poisoned]
|
I lost the ghstack info to resubmit to this PR. superseded by #8647 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In preparation for replacing the checked-in files in shim/ with https://github.com/facebook/buck2-shims-meta as a submodule. The portions of this diff that are not a pure move are: